Bug 1149352

Summary:	always fullscreen for SPICE-xpi
Product:	Red Hat Enterprise Linux 7	Reporter:	Jonathon Jongsma <jjongsma>
Component:	virt-viewer	Assignee:	Virt Viewer Maint <virt-viewer-maint>
Status:	CLOSED ERRATA	QA Contact:	Virtualization Bugs <virt-bugs>
Severity:	high	Docs Contact:
Priority:	high
Version:	7.1	CC:	codong, cww, dblechte, djasa, dyuan, ecohen, fidencio, gklein, iheim, jjongsma, lsurette, michal.skrivanek, mkalinin, mkrcmari, mzhan, ofrenkel, pnovotny, rbalakri, Rhev-m-bugs, tjamrisk, tpelka, tzheng, vehrlich, yeylon
Target Milestone:	rc
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:	virt
Fixed In Version:	virt-viewer-0.6.0-8.el7	Doc Type:	Bug Fix
Doc Text:	Cause: CONTROLLER_AUTO_DISPLAY_RES flag is always set when using the RHEVM portal. Consequence: Client is always opened in the full screen mode. Fix: Ignore CONTROLLER_AUTO_DISPLAY_RES flag. Result: Client is opened in full screen mode only when is set to full screen.	Story Points:	---
Clone Of:	1144449
Clones:	1155764 (view as bug list)		Environment:
Last Closed:	2015-03-05 13:39:59 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1144449, 1155764

Description Jonathon Jongsma 2014-10-03 19:50:39 UTC

+++ This bug was initially created as a clone of Bug #1144449 +++

Description of problem:
UserPortal passing always fullscreen=1 option, even if .vv file includes fulscreen=0. 

Version-Release number of selected component (if applicable):
Red Hat Enterprise Virtualization Manager Version: 3.5.0-0.10.master.el6ev

How reproducible:
100%

Steps to Reproduce:
1. have a win guest with tools installed 
2. uncheck "Open Full Screen" in console oprions
3.

Actual results:
guest system start in fullscreen

Expected results:
guest system should start in window

Additional info:

--- Additional comment from Tomas Pelka on 2014-09-19 09:15:44 EDT ---

I forgot to mention that I got this issue on:

Client: Rhel7.1
Host: Rhel6.6
Guest: W7 64b

--- Additional comment from Vaclav Ehrlich on 2014-09-22 07:14:29 EDT ---

Same here:
Client RHEL6.6, spice-xpi-2.7-25.el6.x86_64
Guest Windows 7 32b

--- Additional comment from Frantisek Kobzik on 2014-09-22 08:24:13 EDT ---

Guys, could someone check if this behavior is reproducible also without guest tools? 

(I did a quick naive test with spice-xpi from fedora 20 and FF 32 and it seems ok.)

--- Additional comment from Vaclav Ehrlich on 2014-09-22 08:39:58 EDT ---

Yes we can ...

--- Additional comment from Vaclav Ehrlich on 2014-09-22 08:47:15 EDT ---

Without RHEV-Tools (3.5.2) it seems to work (also with spice-xpi) ... work means connect in window mode then 'Open in Full Screen' is not checked

--- Additional comment from Michal Skrivanek on 2014-09-24 09:40:54 EDT ---

RHEV sends the correct value as well (fullscreen=0,admin_console=0, when tools _are installed_)
Then the XPI "logic" kicks in, note it's unchanged for a long time, at least 3.1:

SendValue(CONTROLLER_FULL_SCREEN,
     (m_fullscreen == PR_TRUE ? CONTROLLER_SET_FULL_SCREEN : 0) |
     (m_admin_console == PR_FALSE ? CONTROLLER_AUTO_DISPLAY_RES : 0));

so ultimately what's sent to SPICE is correct (CONTROLLER_FULL_SCREEN == 2)

there were some changes in the interpretation of this value in 3.3(3.4?) IIRC…so maybe that's it?

--- Additional comment from Jonathon Jongsma on 2014-10-03 15:19:00 EDT ---

upstream virt-viewer has a fix for this: 7212c8745a4853e99e9a5a1473aa45ce141c2506

Comment 3 CongDong 2014-10-15 09:09:45 UTC

Can reproduce with 0:0.6.0-7.el7:

Steps:
1. Prepare rhevm with 3.5.0-0.10.master.el6ev
Install win7 64bit on rhevm, and install tools in the guest

2. log in user portal, uncheck the "open in fullscreen" and "Browser plugin" mode.

3. Click "console" to connect the guest

Result: virt-viewer will open guest with fullscreen mode.

VERIFY with virt-viewer-0.6.0-8.el7.x86_64
Steps are same with above.

Result:
virt-viewer open the guest with window mode.
Also test with native client mode, the result is correct.

As the result, set VERIFIED.

Comment 7 Michal Skrivanek 2014-10-30 15:25:30 UTC

*** Bug 1144449 has been marked as a duplicate of this bug. ***

Comment 9 errata-xmlrpc 2015-03-05 13:39:59 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2015-0295.html