Bug 1149524

Summary:	Review Request: perl-Digest-Whirlpool - Interface to Whirlpool hash algorithm
Product:	[Fedora] Fedora	Reporter:	Denis Fateyev <denis>
Component:	Package Review	Assignee:	David Dick <ddick>
Status:	CLOSED WONTFIX	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	ddick, package-review, perl-devel, ppisar
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2021-09-19 22:55:35 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Denis Fateyev 2014-10-05 20:10:31 UTC

Spec URL: http://www.fateyev.com/RPMS/Fedora20/testing/perl-Digest-Whirlpool.spec
SRPM URL: http://www.fateyev.com/RPMS/Fedora20/testing/SRPMS/perl-Digest-Whirlpool-2.03-1.fc20.denf.src.rpm
Description: This module provides an interface to Whirlpool hash algorithm.
Whirlpool is a 512-bit, collision-resistant, one-way hash function developed by Paulo S. L. M. Barreto and Vincent Rijmen. It has been recommended by the NESSIE project (along with SHA-256/384/512) and adopted as ISO/IEC 10118-3.
This module subclasses Digest::base and can be used either directly or through the Digest meta-module.
Fedora Account System Username: dfateyev

Koji scratch builds:
https://koji.fedoraproject.org/koji/taskinfo?taskID=7771340 (Rawhide)
https://koji.fedoraproject.org/koji/taskinfo?taskID=7771336 (Fedora 21)
https://koji.fedoraproject.org/koji/taskinfo?taskID=7771351 (EPEL 7)
https://koji.fedoraproject.org/koji/taskinfo?taskID=7771347 (EPEL 6)

Comment 1 David Dick 2014-10-07 10:52:26 UTC

This package has got a bundled library from http://www.larc.usp.br/~pbarreto/whirlpool.zip in it.  Unfortunately, this library has not yet been packaged for Fedora.

i think you'll need to package up libwhirlpool first and then have perl-Digest-Whirlpool depend on it.

Failing that, you could try to get an exception from the no bundled libraries policy https://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries#Some_reasons_you_might_be_granted_an_exception

Comment 2 Denis Fateyev 2014-10-07 19:39:00 UTC

Right. Silly me, I knew that but just overlooked that.
I will prepare libwhirlpool package request when time permits.

Comment 3 Package Review 2020-07-10 00:50:42 UTC

This is an automatic check from review-stats script.

This review request ticket hasn't been updated for some time, but it seems
that the review is still being working out by you. If this is right, please
respond to this comment clearing the NEEDINFO flag and try to reach out the
submitter to proceed with the review.

If you're not interested in reviewing this ticket anymore, please clear the
fedora-review flag and reset the assignee, so that a new reviewer can take
this ticket.

Without any reply, this request will shortly be resetted.

Comment 4 Denis Fateyev 2020-07-10 19:06:59 UTC

Well, I still use "perl-Digest-Whirlpool" in several legacy projects, so I believe we could complete and finish this package review.
I need to prepare a patch that would allow to unbundle Whirlpool code.
BTW, I have prepared and packaged "libwhirlpool" library many years ago.

Comment 5 David Dick 2020-07-17 02:29:25 UTC

Hi Denis, can you get someone else to look at this.  I'm just flat out atm.

Comment 6 Petr Pisar 2020-07-20 11:20:59 UTC

Denis, prepare the patch, apply it from the spec file and link the updated spec and SRPM here. Then I (or anybody else) can review it.

Comment 7 Denis Fateyev 2021-09-19 22:55:35 UTC

Unfortunately, switching from the static code bundle to a shared library usage requires more XS details knowledge (and even more testing afterwards).
In legacy Perl projects, I have already switched from Whirlpool implementation to SHA-3 hashes.
I am no longer interested in supporting 'Digest::Whirlpool', therefore I'm closing the "perl-Digest-Whirlpool" package review request.
At the same time, I still use "libwhirlpool" functionality in other non-Perl based projects.