Bug 1149723

Summary:	Self-heal on dispersed volumes does not restore the correct date
Product:	[Community] GlusterFS	Reporter:	Xavi Hernandez <jahernan>
Component:	disperse	Assignee:	Xavi Hernandez <jahernan>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	mainline	CC:	bugs
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.7.0	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:
Clones:	1149725 (view as bug list)		Environment:
Last Closed:	2015-05-14 17:27:54 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1149725

Description Xavi Hernandez 2014-10-06 14:23:13 UTC

Description of problem:

When a file is missing or corrupt on a brick of a dispersed volume, self-heal repairs it, but the modification time is not updated correctly (it contains the time at which self-heal healed the file, not the original modification time of the file).

Version-Release number of selected component (if applicable): master


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Anand Avati 2014-10-06 14:40:59 UTC

REVIEW: http://review.gluster.org/8905 (ec: Fix incorrect management of healed bricks) posted (#1) for review on master by Xavier Hernandez (xhernandez)

Comment 2 Anand Avati 2014-10-08 08:58:23 UTC

REVIEW: http://review.gluster.org/8905 (ec: Fix incorrect management of healed bricks) posted (#2) for review on master by Xavier Hernandez (xhernandez)

Comment 3 Anand Avati 2014-10-08 12:35:01 UTC

REVIEW: http://review.gluster.org/8905 (ec: Fix incorrect management of healed bricks) posted (#3) for review on master by Xavier Hernandez (xhernandez)

Comment 4 Anand Avati 2014-10-20 10:40:08 UTC

COMMIT: http://review.gluster.org/8905 committed in master by Vijay Bellur (vbellur) 
------
commit 8ea1eaf46153b56fb4c652a8eb9fb95a49038373
Author: Xavier Hernandez <xhernandez>
Date:   Mon Oct 6 16:34:58 2014 +0200

    ec: Fix incorrect management of healed bricks
    
    The final lookup made to restore final file attributes after a self-heal
    did clear the mask of bad bricks, causing that the final setattr won't
    modify any brick at all. This caused that some attriutes, specially the
    modification time of the file didn't get updated properly.
    
    Now the mask of healed bricks is saved before doing the last lookup.
    It's also used to correctly report the repaired bricks.
    
    Change-Id: Ib94083c9e1b562515dfb54f9574120f1f031dccc
    BUG: 1149723
    Signed-off-by: Xavier Hernandez <xhernandez>
    Reviewed-on: http://review.gluster.org/8905
    Reviewed-by: Dan Lambright <dlambrig>
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 5 Niels de Vos 2015-05-14 17:27:54 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 6 Niels de Vos 2015-05-14 17:35:38 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 7 Niels de Vos 2015-05-14 17:38:00 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 8 Niels de Vos 2015-05-14 17:44:02 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user