Bug 1149863

Summary:	Option transport.socket.bind-address ignored
Product:	[Community] GlusterFS	Reporter:	Niels de Vos <ndevos>
Component:	glusterd	Assignee:	Niels de Vos <ndevos>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	urgent	Docs Contact:
Priority:	unspecified
Version:	mainline	CC:	bugs
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	glusterfs-3.7.0	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	1149857	Environment:
Last Closed:	2015-05-14 17:27:55 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1149857, 1151745

Description Niels de Vos 2014-10-06 19:13:45 UTC

+++ This bug was initially created as a clone of Bug #1149857 +++
+++                                                           +++
+++ This bug has been filed to get a fix in mainline, when    +++
+++ a patch has been merged, please post it to the bugs       +++
+++ listed in the 'blocks' field.                             +++

Description of problem: when setting transport.socket.bind-address it is ignored except for actually binding the glusterd daemon. Basically NFS, SHD and everything else tries to connect to 127.0.0.1:24007 instead of the actual address bound. This means FUSE is the only option for connects and of course the volume get corrupted shortly after.

Look in xlators/mgmt/glusterd/src/glusterd-utils.c:glusterd_nodesvc_start() for possible fix. ie:

glusterd_nodesvc_start() calls runner_add_args( ... , "-s", "localhost", ...)

above provided by ndevos in IRC


Version-Release number of selected component (if applicable): 3.5.2


How reproducible: set transport.socket.bind-address option and restart. viola!


Steps to Reproduce:
1. set transport.socket.bind-address option
2. restart glusterfs-server
3.

Actual results: no NFS, no SHD and anything else that attempts to connect to 127.0.0.1:24007


Expected results: it should work


Additional info:

--- Additional comment from Charles Williams on 2014-10-06 21:04:47 CEST ---

forgot to add:

in the "volume management" section of glusterd.vol is where you can set this "option transport.socket.bind-address 123.123.123.123"

Comment 1 Anand Avati 2014-10-06 21:37:59 UTC

REVIEW: http://review.gluster.org/8908 (glusterd: pass the bind-address to starting services) posted (#1) for review on master by Niels de Vos (ndevos)

Comment 2 Anand Avati 2014-10-07 08:19:22 UTC

REVIEW: http://review.gluster.org/8908 (glusterd: pass the bind-address to starting services) posted (#2) for review on master by Niels de Vos (ndevos)

Comment 3 Anand Avati 2014-10-07 08:19:25 UTC

REVIEW: http://review.gluster.org/8910 (glusterd: make bricks respect 'transport.socket.bind-address') posted (#1) for review on master by Niels de Vos (ndevos)

Comment 4 Anand Avati 2014-10-08 02:57:23 UTC

COMMIT: http://review.gluster.org/8908 committed in master by Krishnan Parthasarathi (kparthas) 
------
commit 283fa797f4bf98130b42c36972305b8cb6e5aaaf
Author: Niels de Vos <ndevos>
Date:   Mon Oct 6 22:51:22 2014 +0200

    glusterd: pass the bind-address to starting services
    
    When the transport.socket.bind-address option is set to a hostname or
    ip-address, the services started by GlusterD fail to connect to the
    management daemon. GlusterD always forces the services to connect to the
    "localhost" hostname, even if it is not listening on that address.
    
    GlusterD should take the transport.socket.bind-address option into
    consideration, and pass that to the glusterfs-clients with the -s or
    --volfile commandline parameter.
    
    Note that this is not a change that removes all hard-coded dependencies
    on "localhost". This change merely makes it possible to start required
    services when the transport.socket.bind-address option is set.
    
    Change-Id: I36a0ed6c69342e6327adc258fea023929055d7f2
    BUG: 1149863
    Signed-off-by: Niels de Vos <ndevos>
    Reviewed-on: http://review.gluster.org/8908
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Jeff Darcy <jdarcy>
    Reviewed-by: Krishnan Parthasarathi <kparthas>
    Tested-by: Krishnan Parthasarathi <kparthas>

Comment 5 Anand Avati 2014-10-08 13:22:50 UTC

REVIEW: http://review.gluster.org/8910 (glusterd: make bricks respect 'transport.socket.bind-address') posted (#2) for review on master by Niels de Vos (ndevos)

Comment 6 Anand Avati 2014-10-09 04:10:12 UTC

COMMIT: http://review.gluster.org/8910 committed in master by Krishnan Parthasarathi (kparthas) 
------
commit 430b874c4f1a171c106a9e1e6507e14e79805a1d
Author: Niels de Vos <ndevos>
Date:   Tue Oct 7 10:08:20 2014 +0200

    glusterd: make bricks respect 'transport.socket.bind-address'
    
    When GlusterD starts the brick processes, these will listen on all
    interfaces. When the 'transport.socket.bind-address' option is set in
    glusterd.vol, the brick processes should only listen on the specified
    hostname or IP-address.
    
    Change-Id: I8e7d1f294904081137c23f3446261329d0d13bba
    BUG: 1149863
    Signed-off-by: Niels de Vos <ndevos>
    Reviewed-on: http://review.gluster.org/8910
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Krishnan Parthasarathi <kparthas>
    Tested-by: Krishnan Parthasarathi <kparthas>

Comment 7 Niels de Vos 2015-05-14 17:27:55 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 8 Niels de Vos 2015-05-14 17:35:38 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 9 Niels de Vos 2015-05-14 17:38:00 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 10 Niels de Vos 2015-05-14 17:44:08 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user