Bug 1150064

Summary:	Wrong confirm 'rhq.autoinstall.server.admin.password' should report error message on JON install
Product:	[JBoss] JBoss Operations Network	Reporter:	Jeeva Kandasamy <jkandasa>
Component:	Installer	Assignee:	John Mazzitelli <mazz>
Status:	CLOSED CURRENTRELEASE	QA Contact:	Jeeva Kandasamy <jkandasa>
Severity:	low	Docs Contact:
Priority:	unspecified
Version:	JON 3.3.0	CC:	jkandasa, jshaughn, mfoley
Target Milestone:	ER05
Target Release:	JON 3.3.0
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-12-11 14:04:24 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Jeeva Kandasamy 2014-10-07 11:33:37 UTC

Description of problem:
If we enter different 'rhq.autoinstall.server.admin.password' and confirm password on console, should report error.

-----------snap----------------
[hudson@jeeva-er04-vhi bin]$ ./rhqctl install
07:19:10,233 INFO  [org.jboss.modules] JBoss Modules version 1.3.3.Final-redhat-1

The [rhq.autoinstall.server.admin.password] property is required but not set in [rhq-server.properties].
Do you want to set [rhq.autoinstall.server.admin.password] value now?
yes|no: yes
rhq.autoinstall.server.admin.password (enter as plain text): 
Confirm:
rhq.autoinstall.server.admin.password (enter as plain text): 
rhq.autoinstall.server.admin.password (enter as plain text): 
Confirm:
rhq.autoinstall.server.admin.password (enter as plain text): 
rhq.autoinstall.server.admin.password (enter as plain text): 
Confirm:
rhq.autoinstall.server.admin.password (enter as plain text): 



Version-Release number of selected component (if applicable):
JBoss Operations Network
Version : 3.3.0.ER04
Build Number : 99d2107:d7c537e
GWT Version : 2.5.0
SmartGWT Version : 3.0p

How reproducible:
always

Steps to Reproduce:
1. leave blank 'rhq.autoinstall.server.admin.password' in rhq-server.properties file
2. execute './rhqctl'

Comment 3 John Mazzitelli 2014-10-08 15:38:00 UTC

So the only issue here is you want to see a message like "Passwords did not match - try again"  ??

This should NOT allow you to proceed further. Until you confirm the password correctly, it should continually loop until you do so. did this procede further in the isntall and the install completed? If so, what did it use for password?

Comment 4 Jeeva Kandasamy 2014-10-09 05:05:22 UTC

Yes, only issue is here, want to see error message something like as you mentioned, "Passwords did not match - try again".

In the current approach, It is not showing the error message, but until we confirm the password correctly, it is continually loop until we do so.

Only error message is missing.

Comment 5 John Mazzitelli 2014-10-09 19:15:23 UTC

master commit:

commit 8e70ef29bfdf410fc68eb5bb20ecc49ce5f6111a
Author: John Mazzitelli <mazz>
Date:   Thu Oct 9 15:13:03 2014 -0400

    BZ 1150064 - print message telling user the password did not confirm

release/jon3.3.x commit:

commit c6a1d47f097e3c77551ab66151ee762a364783a0
Author: John Mazzitelli <mazz>
Date:   Thu Oct 9 15:13:03 2014 -0400

    BZ 1150064 - print message telling user the password did not confirm
    (cherry picked from commit 8e70ef29bfdf410fc68eb5bb20ecc49ce5f6111a)

Comment 7 Simeon Pinder 2014-10-21 20:24:39 UTC

Moving to ON_QA as available to test with the latest brew build:
https://brewweb.devel.redhat.com//buildinfo?buildID=394734

Comment 8 Jeeva Kandasamy 2014-10-27 11:39:53 UTC

Works as expected. 

Version:
JBoss Operations Network
Version : 3.3.0.ER05
Build Number : 92b6d6a:2cdb528
GWT Version : 2.5.0
SmartGWT Version : 3.0p


Log:

The [rhq.autoinstall.server.admin.password] property is required but not set in [rhq-server.properties].
Do you want to set [rhq.autoinstall.server.admin.password] value now?
yes|no: yes
rhq.autoinstall.server.admin.password (enter as plain text): 
Confirm:
rhq.autoinstall.server.admin.password (enter as plain text): 
Did not match. Please try again.
rhq.autoinstall.server.admin.password (enter as plain text):