Bug 1150147

Created attachment 944607 [details]
Relevant tf file from cloned bug

Nominating as a 21 Beta Blocker: https://fedoraproject.org/wiki/Fedora_21_Beta_Release_Criteria#Hardware_and_firmware_RAID , "The installer must be able to detect and install to hardware or firmware RAID storage devices." I have reproduced this on my Intel firmware RAID test array.

Is there any way to test this before a new install image is generated?

Back at drawing board.

(In reply to Jeremy Rimpo from comment #3)
> Is there any way to test this before a new install image is generated?

You can make your own updates.img using scripts/makeupdates in blivet directory.

Also pushed to master.

anaconda-21.48.10-1.fc21, pykickstart-1.99.63-2.fc21, python-blivet-0.61.5-1.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/pykickstart-1.99.63-2.fc21,python-blivet-0.61.5-1.fc21,anaconda-21.48.10-1.fc21

Discussed at 2014-10-15 blocker review meeting: http://meetbot.fedoraproject.org/fedora-blocker-review/2014-10-15/f21-blocker-review.2014-10-15-16.04.log.txt . Accepted as a blocker per criterion cited in c#2.

Package anaconda-21.48.10-1.fc21, pykickstart-1.99.63-2.fc21, python-blivet-0.61.5-1.fc21:
* should fix your issue,
* was pushed to the Fedora 21 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing anaconda-21.48.10-1.fc21 pykickstart-1.99.63-2.fc21 python-blivet-0.61.5-1.fc21'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2014-12944/pykickstart-1.99.63-2.fc21,python-blivet-0.61.5-1.fc21,anaconda-21.48.10-1.fc21
then log in and leave karma (feedback).

Created attachment 947747 [details]
Error log from anaconda/blivet 0.61.5

Unfortunately, I'm now being greeted with yet another error. I tried both updating the version of anaconda and python-blivet as well as generating an updates.img from the current source release. The result was the same.

I will provide full error report output, if needed.

If stack trace looks like this one

anaconda 19.31.100-1 exception report
Traceback (most recent call first):
  File "/tmp/updates/blivet/devices.py", line 2440, in _addParent
    getattr(member.format, self._formatUUIDAttr) != self.uuid:
  File "/tmp/updates/blivet/devices.py", line 3964, in _addParent
    super(MDRaidArrayDevice, self)._addParent(member)
  File "/tmp/updates/blivet/devices.py", line 181, in append
    self.appendfunc(y)
  File "/tmp/updates/blivet/devices.py", line 323, in _setParentList
    self._parents.append(parent)
  File "/tmp/updates/blivet/devices.py", line 266, in __init__
    self.parents = parents
  File "/tmp/updates/blivet/devices.py", line 568, in __init__
    Device.__init__(self, name, parents=parents)
  File "/tmp/updates/blivet/devices.py", line 2410, in __init__
    super(ContainerDevice, self).__init__(*args, **kwargs)
  File "/tmp/updates/blivet/devices.py", line 3745, in __init__
    sysfsPath=sysfsPath)
  File "/tmp/updates/blivet/devicetree.py", line 1060, in addUdevDiskDevice
    sysfsPath=sysfs_path, **kwargs)
  File "/tmp/updates/blivet/devicetree.py", line 1193, in addUdevDevice
    device = self.addUdevDiskDevice(info)
  File "/tmp/updates/blivet/devicetree.py", line 921, in addUdevPartitionDevice
    self.addUdevDevice(new_info)
  File "/tmp/updates/blivet/devicetree.py", line 1196, in addUdevDevice
    device = self.addUdevPartitionDevice(info)
  File "/tmp/updates/blivet/devicetree.py", line 693, in addUdevLVDevice
    self.addUdevDevice(pv_info)
  File "/tmp/updates/blivet/devicetree.py", line 1175, in addUdevDevice
    device = self.addUdevLVDevice(info)
  File "/tmp/updates/blivet/devicetree.py", line 2169, in _populate
    self.addUdevDevice(dev)
  File "/tmp/updates/blivet/devicetree.py", line 2104, in populate
    self._populate()
  File "/tmp/updates/blivet/__init__.py", line 482, in reset
    self.devicetree.populate(cleanupOnly=cleanupOnly)
  File "/tmp/updates/blivet/__init__.py", line 186, in storageInitialize
    storage.reset()
  File "/usr/lib64/python2.7/threading.py", line 764, in run
    self.__target(*self.__args, **self.__kwargs)
  File "/usr/lib64/python2.7/site-packages/pyanaconda/threads.py", line 211, in run
    threading.Thread.run(self, *args, **kwargs)
AttributeError: 'DeviceFormat' object has no attribute 'mdUuid'

no need to tell me anymore, I should be pushing a patch in a bit.

Yep. That's the error. Only difference between update methods is the path to the python scripts.

And pushed.

Now something else:

Traceback (most recent call last):
  File "/usr/lib64/python2.7/site-packages/pyanaconda/threads.py", line 227, in run
    threading.Thread.run(self, *args, **kwargs)
  File "/usr/lib64/python2.7/threading.py", line 766, in run
    self.__target(*self.__args, **self.__kwargs)
  File "/usr/lib64/python2.7/site-packages/pyanaconda/packaging/__init__.py", line 1222, in _runThread
    threadMgr.wait(THREAD_STORAGE)
  File "/usr/lib64/python2.7/site-packages/pyanaconda/threads.py", line 112, in wait
    self.raise_if_error(name)
  File "/usr/lib64/python2.7/site-packages/pyanaconda/threads.py", line 227, in run
    threading.Thread.run(self, *args, **kwargs)
  File "/usr/lib64/python2.7/threading.py", line 766, in run
    self.__target(*self.__args, **self.__kwargs)
  File "/tmp/updates/blivet/__init__.py", line 183, in storageInitialize
    storage.reset()
  File "/tmp/updates/blivet/__init__.py", line 479, in reset
    self.devicetree.populate(cleanupOnly=cleanupOnly)
  File "/tmp/updates/blivet/devicetree.py", line 2105, in populate
    self._populate()
  File "/tmp/updates/blivet/devicetree.py", line 2170, in _populate
    self.addUdevDevice(dev)
  File "/tmp/updates/blivet/devicetree.py", line 1180, in addUdevDevice
    device = self.addUdevLVDevice(info)
  File "/tmp/updates/blivet/devicetree.py", line 698, in addUdevLVDevice
    self.addUdevDevice(pv_info)
  File "/tmp/updates/blivet/devicetree.py", line 1201, in addUdevDevice
    device = self.addUdevPartitionDevice(info)
  File "/tmp/updates/blivet/devicetree.py", line 926, in addUdevPartitionDevice
    self.addUdevDevice(new_info)
  File "/tmp/updates/blivet/devicetree.py", line 1198, in addUdevDevice
    device = self.addUdevDiskDevice(info)
  File "/tmp/updates/blivet/devicetree.py", line 1065, in addUdevDiskDevice
    sysfsPath=sysfs_path, **kwargs)
  File "/tmp/updates/blivet/devices.py", line 3733, in __init__
    sysfsPath=sysfsPath)
  File "/tmp/updates/blivet/devices.py", line 2349, in __init__
    super(ContainerDevice, self).__init__(*args, **kwargs)
  File "/tmp/updates/blivet/devices.py", line 570, in __init__
    Device.__init__(self, name, parents=parents)
  File "/tmp/updates/blivet/devices.py", line 268, in __init__
    self.parents = parents
  File "/tmp/updates/blivet/devices.py", line 325, in _setParentList
    self._parents.append(parent)
  File "/tmp/updates/blivet/devices.py", line 183, in append
    self.appendfunc(y)
  File "/tmp/updates/blivet/devices.py", line 3968, in _addParent
    if self.status and member.format.exists:
  File "/tmp/updates/blivet/devices.py", line 4006, in status
    if os.path.exists(self.path) and not self.sysfsPath:
AttributeError: 'MDRaidArrayDevice' object has no attribute 'sysfsPath'

This is a superclass constructor initalization ordering bug.

We're checking the status of the array while adding its parents.

Ordering is:

_memberDevices = ...
_totalDevices = ...
ContainerDevice.__init__
    formatClass = ...
    StorageDevice.__init__
        exists = ...
        uuid = ...
        Device.__init__
            util.ObjectID = ...
            kids = ...
            _name = ...
            parents = ...   (invokes _addParent() which requires sysfsPath)
        sysfsPath = ... (too late!)

This is a bit funny, because _addParent() is being invoked during device discovery, and shouldn't really need to be doing something w/ the actual device.
But, there is a reason, the size needs to be discovered while the array is up, so the code takes every chance it gets.
            
Best thing to do is to reorder the two assignments.

Makes sense. As soon as I have a commit to pull, I'll give it another go. Hopefully it'll be the last time!

Hopefully...

Created attachment 948009 [details]
AttributeError: 'MDRaidArrayDevice' object has no attribute '_partedDevice'

Unfortunately, we've run into another one. It took a lot longer to hit this one. Seems to be another missing attribute.

One line further and about the same number of stack frames deep. Basically the same problem, however, and with, presumably, the same solution.

Could you try with updates image http://mulhern.fedorapeople.org/1150147.img and see if you get past this?

- mulhern

Tentative success!

I dug in and was able to correctly select/modify partitions from the RAID drive to set up the installation. There was some kind of atk-bridge/dbus warning on startup, but I think that is a totally separate issue. Do I need to run an actuall install to the drive to totally verify - or does it look good now?

(In reply to Jeremy Rimpo from comment #20)
> Tentative success!
> 
> I dug in and was able to correctly select/modify partitions from the RAID
> drive to set up the installation. There was some kind of atk-bridge/dbus
> warning on startup, but I think that is a totally separate issue. Do I need
> to run an actuall install to the drive to totally verify - or does it look
> good now?

That's good news.

One never knows what will happen...but I think that if you ran into a bug during the install that you would probably want to file it as a separate issue.

These problems all fell under the same category, "Unanticipated problems when instantiating ContainerDevices that happen to be MDRaidArrayDevices", and I think any subsequent problem would have to be something different.

Thanks for the quick turnaround.

- mulhern

anaconda-21.48.11-1.fc21, python-blivet-0.61.6-1.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/python-blivet-0.61.6-1.fc21,anaconda-21.48.11-1.fc21

anaconda-21.48.10-1.fc21, pykickstart-1.99.63-2.fc21, python-blivet-0.61.5-1.fc21 has been pushed to the Fedora 21 stable repository.  If problems still persist, please make note of it in this bug report.

anaconda-21.48.12-1.fc21, python-blivet-0.61.7-1.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/python-blivet-0.61.7-1.fc21,anaconda-21.48.12-1.fc21

FWIW kparal and I are both now hitting https://bugzilla.redhat.com/show_bug.cgi?id=1156354 . dlehman has a fix for that, and with that fix the install finally completes for me, but on booting the installed system I hit https://bugzilla.redhat.com/show_bug.cgi?id=1156614 .