Bug 1150445
| Summary: | Review Request: Random123 - Library of random number generators | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Ankur Sinha (FranciscoD) <sanjay.ankur> |
| Component: | Package Review | Assignee: | José Matos <jamatos> |
| Status: | CLOSED NEXTRELEASE | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | e, jamatos, package-review |
| Target Milestone: | --- | Flags: | jamatos:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | 1.08-3.fc22 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2015-08-15 02:07:21 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1249094 | ||
|
Description
Ankur Sinha (FranciscoD)
2014-10-08 10:34:46 UTC
I am willing to review this package. Presently it fails in at least two instances: 1) on doxygen: + cd Random123-1.08 + pushd docs + doxygen . Error: file `.' not found 2) on latex: ! LaTeX Error: File `adjustbox.sty' not found. There are two options, either you add BR tex(adjustbox.sty) or BR texlive-collection-latexextra that provides this and other latex packages. Please fix this problems before proceeding with the review. :-) Hi Jose, Thank you for reviewing this package. I've fixed the errors. Updated spec/srpm: https://ankursinha.fedorapeople.org/neuroscience-research-copr/Random123.spec https://ankursinha.fedorapeople.org/neuroscience-research-copr/Random123-1.08-2.fc22.src.rpm I'm using a copr repo to test the builds now: https://copr.fedoraproject.org/coprs/ankursinha/neuroscience-research/builds/ Cheers, Ankur *** Bug 1249097 has been marked as a duplicate of this bug. *** Hi Ankur, fedora-review raises two problems, that seem legitimate in my view. :-) - If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. Note: License file LICENSE is marked as %doc instead of %license See: http://fedoraproject.org/wiki/Packaging/LicensingGuidelines#License_Text The license file is marked as %doc and not as license. If you intend to support EL6 or older, it is enough to add %{!?_licensedir:%global license %doc} - Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 1454080 bytes in 68 files. See: http://fedoraproject.org/wiki/Packaging/Guidelines#PackageDocumentation This seems to me as a reasonable suggestion, what do you think? Hi Jose, Makes sense. Updated spec/srpm: https://ankursinha.fedorapeople.org/neuroscience-research-copr/Random123.spec https://ankursinha.fedorapeople.org/neuroscience-research-copr/Random123-1.08-3.fc22.src.rpm Could you please set the review flag to the bug so that this doesn't show up on the "unaccepted review list"? :) Thanks, Ankur (In reply to Ankur Sinha (FranciscoD) from comment #5) > Hi Jose, > > Makes sense. > > Updated spec/srpm: > https://ankursinha.fedorapeople.org/neuroscience-research-copr/Random123.spec > https://ankursinha.fedorapeople.org/neuroscience-research-copr/Random123-1. > 08-3.fc22.src.rpm OK. > Could you please set the review flag to the bug so that this doesn't show up > on the "unaccepted review list"? :) :-) Thanks for the remainder. :-) In any case I set it to +. :-) > Thanks, > Ankur The package is easy, most of it is documentation. The license is acceptable and the spec well written following the fedora guidelines. The package is approved. Thanks for the quick review Jose! New Package SCM Request ======================= Package Name: Random123 Short Description: Library of random number generators Upstream URL: http://www.deshawresearch.com/resources_random123.html Owners: ankursinha Branches: f22 f23 InitialCC: Git done (by process-git-requests). The scm request doesn't seem to have worked. Was advised to reset the flag. New Package SCM Request ======================= Package Name: Random123 Short Description: Library of random number generators Upstream URL: http://www.deshawresearch.com/resources_random123.html Owners: ankursinha Branches: f22 f23 InitialCC: Git done (by process-git-requests). Random123-1.08-3.fc23 has been submitted as an update for Fedora 23. https://admin.fedoraproject.org/updates/Random123-1.08-3.fc23 Random123-1.08-3.fc22 has been submitted as an update for Fedora 22. https://admin.fedoraproject.org/updates/Random123-1.08-3.fc22 Random123-1.08-3.fc23 has been pushed to the Fedora 23 testing repository. Random123-1.08-3.fc23 has been pushed to the Fedora 23 stable repository. Random123-1.08-3.fc22 has been pushed to the Fedora 22 stable repository. If problems still persist, please make note of it in this bug report. |