Bug 1150858

Summary:	virt-sparsify: unknown option `--check-tmpdir=ignore'
Product:	[Fedora] Fedora	Reporter:	Lingfei Kong <lkong>
Component:	libguestfs	Assignee:	Richard W.M. Jones <rjones>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	low	Docs Contact:
Priority:	medium
Version:	20	CC:	leiwang, mbooth, ptoscano, rjones, virt-maint, wshi
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-05-29 13:11:02 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Lingfei Kong 2014-10-09 05:13:24 UTC

Description of problem:
virt-sparsify can not recognize '--check-tmpdir' option


Version-Release number of selected component (if applicable):
libguestfs-tools-c-1.26.9-1.fc20


How reproducible:
100%


Steps to Reproduce:
$virt-sparsify rhel6.6.img rhel6.6.imgg --tmp /home/ --check-tmpdir=ignore
virt-sparsify: unknown option `--check-tmpdir=ignore'.
virt-sparsify: sparsify a virtual machine disk

 virt-sparsify [--options] indisk outdisk

 virt-sparsify [--options] --in-place disk

A short summary of the options is given below.  For detailed help please


Actual results:
Command failed with the following error message:
virt-sparsify: unknown option `--check-tmpdir=ignore'.


Expected results:
Command finished successfully.


Additional info:

Comment 1 Richard W.M. Jones 2014-10-09 08:07:49 UTC

It should be `--check-tmpdir ignore' (without the `=' sign).
The manual page is wrong.

Comment 2 Richard W.M. Jones 2014-10-09 08:28:01 UTC

One line reproducer.

With `=':

guestfish -N fs exit && virt-sparsify test1.img test2.img --tmp /tmp --check-tmpdir=ignore

Without `=':

guestfish -N fs exit && virt-sparsify test1.img test2.img --tmp /tmp --check-tmpdir ignore

Note that on RHEL 7.1 and Fedora >= 22 the `=' form should NOT fail.
That is because these distros contain a non-upstream hack to the
OCaml argument parser so that --option=value works.

However the manual page should only document `--check-tmpdir ignore'
because this will work with all OCaml versions, hacked or not.

Comment 3 Richard W.M. Jones 2014-10-09 08:30:55 UTC

Upstream fix:
https://github.com/libguestfs/libguestfs/commit/fbbcc6c6298dc7084891703bdb5af97541c29bdc

I also checked all the other manual pages for OCaml-based tools
and did not find any other instances of the same documentation
mistake.

Comment 5 Fedora End Of Life 2015-05-29 13:03:06 UTC

This message is a reminder that Fedora 20 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 20. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as EOL if it remains open with a Fedora  'version'
of '20'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 20 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.