Bug 1151144

Summary: Unable to add FCP LUN in anaconda GUI
Product: [Fedora] Fedora Reporter: Jan Stodola <jstodola>
Component: anacondaAssignee: Samantha N. Bueno <sbueno>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: 22CC: g.kaviyarasu, jonathan, sbueno, vanmeeuwen+fedora
Target Milestone: ---   
Target Release: ---   
Hardware: s390x   
OS: Linux   
Whiteboard:
Fixed In Version: anaconda-22.20.6-1.fc22 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2015-03-23 07:10:59 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 467765    

Description Jan Stodola 2014-10-09 16:17:51 UTC
Description of problem:
It is not possible to add an FCP LUN using anaconda GUI, no dialog window appears after clicking on the "Add ZFCP LUN..." button. The on_add_zfcp_clicked() method does nothing:

(f21-branch)$ grep -A 2 on_add_zfcp_clicked pyanaconda/ui/gui/spokes/filter.py
    def on_add_zfcp_clicked(self, widget, *args):
        pass

Version-Release number of selected component (if applicable):
anaconda-21.48.9-1

How reproducible:
always

Steps to Reproduce:
1. start vnc installation
2. go to the Installation destination spoke
3. Add a disk...
4. click on the "Add ZFCP LUN..."

Actual results:
no result

Expected results:
able to add an FCP LUN

Comment 1 Samantha N. Bueno 2014-10-09 16:24:00 UTC
Yes, I just need to rebase my patches from rhel7-branch to master/f21-branch....now that I have a compose to test with I'll do this.

Comment 2 Samantha N. Bueno 2015-01-07 17:40:37 UTC
This'll be fixed in rawhide.

Comment 3 Jaroslav Reznik 2015-03-03 17:15:58 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 22 development cycle.
Changing version to '22'.

More information and reason for this action is here:
https://fedoraproject.org/wiki/Fedora_Program_Management/HouseKeeping/Fedora22

Comment 4 Jan Stodola 2015-03-13 16:36:00 UTC
No:

anaconda 22.20.1-1 exception report
Traceback (most recent call first):
  File "/usr/lib64/python2.7/contextlib.py", line 84, in helper
    return GeneratorContextManager(func(*args, **kwds))
  File "/usr/lib64/python2.7/site-packages/pyanaconda/ui/gui/spokes/filter.py", line 638, in on_add_zfcp_clicked
    with self.main_window.enlightbox(self.window, dialog.window):
TypeError: enlightbox() takes exactly 2 arguments (3 given)

patch:

diff --git a/pyanaconda/ui/gui/spokes/filter.py b/pyanaconda/ui/gui/spokes/filter.py
index da1c971..c31ce3e 100644
--- a/pyanaconda/ui/gui/spokes/filter.py
+++ b/pyanaconda/ui/gui/spokes/filter.py
@@ -656,7 +656,7 @@ class FilterSpoke(NormalSpoke):
     def on_add_zfcp_clicked(self, widget, *args):
         dialog = ZFCPDialog(self.data, self.storage)
 
-        with self.main_window.enlightbox(self.window, dialog.window):
+        with self.main_window.enlightbox(dialog.window):
             dialog.refresh()
             dialog.run()
 
-> ASSIGNED

Comment 5 Fedora Update System 2015-03-17 18:42:35 UTC
anaconda-22.20.5-1.fc22 has been submitted as an update for Fedora 22.
https://admin.fedoraproject.org/updates/anaconda-22.20.5-1.fc22

Comment 6 Fedora Update System 2015-03-18 10:39:33 UTC
Package anaconda-22.20.5-1.fc22:
* should fix your issue,
* was pushed to the Fedora 22 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing anaconda-22.20.5-1.fc22'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2015-4126/anaconda-22.20.5-1.fc22
then log in and leave karma (feedback).

Comment 7 Fedora Update System 2015-03-19 18:21:33 UTC
anaconda-22.20.6-1.fc22, python-blivet-1.0.5-1.fc22 has been submitted as an update for Fedora 22.
https://admin.fedoraproject.org/updates/python-blivet-1.0.5-1.fc22,anaconda-22.20.6-1.fc22

Comment 8 Fedora Update System 2015-03-19 18:40:27 UTC
Package anaconda-22.20.5-1.fc22, python-blivet-1.0.4-1.fc22:
* should fix your issue,
* was pushed to the Fedora 22 testing repository,
* should be available at your local mirror within two days.
Update it with:
# su -c 'yum update --enablerepo=updates-testing anaconda-22.20.5-1.fc22 python-blivet-1.0.4-1.fc22'
as soon as you are able to.
Please go to the following url:
https://admin.fedoraproject.org/updates/FEDORA-2015-4126/python-blivet-1.0.4-1.fc22,anaconda-22.20.5-1.fc22
then log in and leave karma (feedback).

Comment 9 Fedora Update System 2015-03-23 07:10:59 UTC
anaconda-22.20.6-1.fc22, python-blivet-1.0.5-1.fc22, libblockdev-0.7-1.fc22 has been pushed to the Fedora 22 stable repository.  If problems still persist, please make note of it in this bug report.