Bug 1151219

Summary:	[RFE] complete the actions supported by bin/ambari_config_update.sh (add, delete, replace, remove)
Product:	[Red Hat Storage] Red Hat Gluster Storage	Reporter:	Jeff Vance <jvance>
Component:	rhs-hadoop-install	Assignee:	Jeff Vance <jvance>
Status:	CLOSED ERRATA	QA Contact:	Martin Kudlej <mkudlej>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	rhgs-3.0	CC:	bchilds, divya, eboyd, jvance, matt, mkudlej, nlevinki
Target Milestone:	Release Candidate	Keywords:	FutureFeature, Triaged, UpcomingRelease, ZStream
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	2.36	Doc Type:	Enhancement
Doc Text:	A new auxillary script has been added to bin directory which supports all actions to modify hadoop configuration files. With this script, users can now add or delete core-site keys and modify core-site property values.	Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-11-24 11:55:27 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1159155

Description Jeff Vance 2014-10-09 19:40:19 UTC

Description of problem:
Today, bin/ambari_config_update.sh only supports append and prepend actions, and is used only to update the "fs.glusterfs.volumes" core-site property value. A companion script, ambari_config.sh (with lots of duplicate code) is invoked to add the "fs.glusters.volume.fuse.<name>" property and value. It will be easier to maintain these scripts if the 2 are combined and all action verbs are supported.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 1 Jeff Vance 2014-10-09 19:42:04 UTC

New actions add, delete, remove, and replace (in addition to the existing append and prepend) are now supported by bin/ambari_config_update.sh. bin/ambari_config.sh is no longer being used.

Comment 4 Martin Kudlej 2014-11-11 17:49:42 UTC

I think that goals for this bug are:
1) merge 2 scripts -> this was not accomplished because user cannot get current value of key from configuration(ambari_config.sh functionality by getting whole config. file), user cannot get config. file content(ambari_config.sh functionality)

2) There is no documentation about what actions mean. I understand what do these actions: add|delete|prepend|append|replace But I was not able to understand what does remove. 

State:
"key1": "value5"

I've tried:
./ambari_config_update.sh --configkey key1 --action remove --cluster TestCluster --configvalue "value5"
No change.

./ambari_config_update.sh --configkey key1 --action remove --cluster TestCluster --configvalue "value3"
WARN: value3 not present in key1; no action needed

./ambari_config_update.sh --configkey key1 --action remove --cluster TestCluster
..help message..

What is purpose of this action, please?

Comment 8 Jeff Vance 2014-11-12 17:10:36 UTC

Martin, I am unsure what you are asking in comment 7. Version 2.36 will remove all occurrences of the passed-in value from the passed-in key with --action remove. However, the assumption is that the prop value is a list of tokens separated by a single comma and no white-space.

Comment 9 Martin Kudlej 2014-11-13 09:19:15 UTC

Ok, I filed bug 1163669 for removing and verify this BZ.

Comment 10 Divya 2014-11-14 08:30:05 UTC

Jeff,

Could you please provide the doc text in the Doc Text field for this bug?

Comment 11 Divya 2014-11-21 08:34:31 UTC

Jeff,

Could you please review the edited doc text for technical accuracy and sign-off?

Comment 12 errata-xmlrpc 2014-11-24 11:55:27 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHEA-2014-1275.html