Bug 1151419

Summary:	Review Request: perl-String-Compare-ConstantTime - Timing side-channel protected string compare
Product:	[Fedora] Fedora	Reporter:	Petr Pisar <ppisar>
Component:	Package Review	Assignee:	Petr Šabata <psabata>
Status:	CLOSED RAWHIDE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	package-review, psabata
Target Milestone:	---	Flags:	psabata: fedora-review+ kevin: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	perl-String-Compare-ConstantTime-0.310-1.fc22	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-10-14 12:44:56 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1153698

Description Petr Pisar 2014-10-10 11:18:01 UTC

Spec URL: https://ppisar.fedorapeople.org/perl-String-Compare-ConstantTime/perl-String-Compare-ConstantTime.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-String-Compare-ConstantTime/perl-String-Compare-ConstantTime-0.310-1.fc22.src.rpm
Description:
This module provides one function "equals" which works like perl's "eq", but
which does not provide a timing side-channel. Such comparison is useful when
matching against a secret string.

Fedora Account System Username: ppisar

Comment 1 Petr Šabata 2014-10-10 11:35:18 UTC

No blockers, approving.

Just add commas around `"equals"' in your %description.

Comment 2 Petr Pisar 2014-10-10 12:39:57 UTC

New Package SCM Request
=======================
Package Name: perl-String-Compare-ConstantTime
Short Description: Timing side-channel protected string compare
Upstream URL: http://search.cpan.org/dist/String-Compare-ConstantTime/
Owners: ppisar jplesnik psabata
Branches: 
InitialCC: perl-sig

Comment 3 Kevin Fenzi 2014-10-13 23:39:08 UTC

Git done (by process-git-requests).

Comment 4 Petr Pisar 2014-10-14 12:44:56 UTC

Thank you for the review and the repository. I added the commas into the description.