Bug 115160

Summary:	Missing return statement ?
Product:	[Fedora] Fedora	Reporter:	d.binderman
Component:	macutils	Assignee:	Than Ngo <than>
Status:	CLOSED WONTFIX	QA Contact:
Severity:	medium	Docs Contact:
Priority:	medium
Version:	1	CC:	bart.martens
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2004-02-12 18:04:41 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description d.binderman 2004-02-07 14:14:42 UTC

Description of problem:

I just tried to compile package macutils-2.0b3-25 from Fedora.

The compiler said

1.

hqx.c(392): remark #1011: missing return statement at end of non-void
function "getqbuf"

The source code is

/* getqbuf(); q format -- read n characters from input into buf */
static getqbuf(buf, n)
    char *buf;
    int n;
{
    int i;

    for(i = 0; i < n; i++) {
        *buf++ = getq();
    }
}

Maybe getqbuf should have void return type ?


Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.
  
Actual results:


Expected results:


Additional info:

Comment 1 Bart Martens 2004-02-11 01:32:28 UTC

There is no return statement missing. The function is only used as a
void function. It would be nice to explictly declare the function as
void. I'm sure that not doing that, does not cause any problems.

Comment 2 Than Ngo 2004-02-12 18:04:41 UTC

the code are old and probably need to be cleaned up.
if someone wants to cleanup, just do it.