Bug 1151812 (nodejs-backbone)
| Summary: | Review Request: nodejs-backbone - Models, Views, Collections, and Events for JavaScript applications | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Dan Callaghan <dcallagh> |
| Component: | Package Review | Assignee: | Lubomir Rintel <lkundrak> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | lkundrak, package-review, shawn |
| Target Milestone: | --- | Flags: | lkundrak:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | nodejs-backbone-1.1.2-2.fc21 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-12-06 09:58:57 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
Dan Callaghan
2014-10-12 02:17:55 UTC
* Named correctly * Versioned correctly * Latest version packaged * License tag correct * License text included * License good for fedora * SPEC file clean and legible, follows nodejs guidelines * Filelist sane * Requires/provides make sense * rpmlint mostly happy * Builds fine in mock 0.) The description of nodejs- and js- package is exactly the same. You may want to explain how are the packages different. 1.) The nodejs- package contains no license text & README. Please add it. (In reply to Lubomir Rintel from comment #1) > 0.) The description of nodejs- and js- package is exactly the same. You may > want to explain how are the packages different. Good idea. > 1.) The nodejs- package contains no license text & README. Please add it. The nodejs- package requires the js- package (which contains the license and README) so we don't need another copy in the nodejs- package, as per <https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Subpackage_Licensing>. Summaries and descriptions updated: https://fedorapeople.org/~dcallagh/nodejs-backbone/nodejs-backbone.spec https://fedorapeople.org/~dcallagh/nodejs-backbone/nodejs-backbone-1.1.2-2.fc21.src.rpm Thank you. APPROVED New Package SCM Request ======================= Package Name: nodejs-backbone Short Description: Models, Views, Collections, and Events for JavaScript applications Upstream URL: http://backbonejs.org/ Owners: dcallagh Branches: f21 epel7 InitialCC: Git done (by process-git-requests). nodejs-backbone-1.1.2-2.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/nodejs-backbone-1.1.2-2.fc21 nodejs-backbone-1.1.2-2.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/nodejs-backbone-1.1.2-2.el7 nodejs-backbone-1.1.2-2.fc21 has been pushed to the Fedora 21 testing repository. nodejs-backbone-1.1.2-2.fc21 has been pushed to the Fedora 21 stable repository. nodejs-backbone-1.1.2-2.el7 has been pushed to the Fedora EPEL 7 stable repository. |