Bug 1151839
| Summary: | Review Request: snowball-c - C stemming algorithm library | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Pranav Kant <pranav913> |
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> |
| Status: | CLOSED WONTFIX | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | rawhide | CC: | mtasaka, opensource, package-review, pranav913 |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2015-07-19 08:41:43 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 201449 | ||
|
Description
Pranav Kant
2014-10-12 13:48:38 UTC
I am sorry, here are the new URLs: Spec URL: http://glug.nith.ac.in/~pranavk/fedora/snowball-c.spec SRPM URL: http://glug.nith.ac.in/~pranavk/fedora/snowball-c-0-0.1.20141012.fc21.src.rpm Consider pointing the optional fedora-review tool at this ticket: fedora-review -b 1151839 It evaluates the "Spec URL:" and "SRPM URL:" lines, downloads the latest files, and performs many checks on test-builds. Not limited to running rpmlint on all packages. > Version: 0 > Release: 0.1.20141012%{?dist} Seems you want to apply these guidelines: https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Snapshot_packages Also, it will be very important to be aware of this: https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Minor_release_bumps_for_old_branches > Source0: http://snowball.tartarus.org/dist/libstemmer_c.tgz snowball-c.src: W: file-size-mismatch libstemmer_c.tgz = 129592, http://snowball.tartarus.org/dist/libstemmer_c.tgz = 129584 > # patch to build shared modules; the upstream doesn't build shared modules' > Patch0: shared-module.patch Dangerous, if there is no collaboration with upstream. Who will ensure API/ABI stability? What about compatibility with other dists? Will you bump from libstemmer.so.0 to libstemmer.so.1 and libstemmer.so.N, increasing the risk that a future upstream release will reintroduce/reuse a SONAME you've used before? https://fedoraproject.org/wiki/Packaging:Guidelines#Packaging_Static_Libraries_2 > %build > make %{?_smp_mflags} https://fedoraproject.org/wiki/Packaging:Guidelines#Compiler_flags > ln -s libstemmer.so.0.0.0 %{buildroot}%{_libdir}/libstemmer.so || : Why the '|| :'? You want the build to fail, if commands like this fail. With a proper %files section, it would fail later anyway. > http://snowball.tartarus.org/index.php | Major events | | September 2014 - Snowball site and software no longer being | actively maintained | The code has all been loaded into Github, and we may still | make very occasional changes. Pranav, do you still want to maintain this? Ah ! Sorry that I lost track of it. I would try to fix the SPEC files and resubmit by next week. (removing needsponsor) | Major events | | September 2014 - Snowball site and software no longer being | actively maintained | The code has all been loaded into Github, and we may still | make very occasional changes. I noticed this, and now do not have any plans to package this for now. |