Bug 1151855
| Summary: | Review Request: php-pear-Date-Holidays-Austria - Driver based class to calculate holidays in Austria | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | josef radinger <cheese> | ||||||
| Component: | Package Review | Assignee: | Nobody's working on this, feel free to take it <nobody> | ||||||
| Status: | CLOSED NOTABUG | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | medium | Docs Contact: | |||||||
| Priority: | medium | ||||||||
| Version: | rawhide | CC: | dsupriadi, fedora, package-review | ||||||
| Target Milestone: | --- | ||||||||
| Target Release: | --- | ||||||||
| Hardware: | All | ||||||||
| OS: | Linux | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | Doc Type: | Bug Fix | |||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2021-08-27 00:45:38 UTC | Type: | --- | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Bug Depends On: | |||||||||
| Bug Blocks: | 201449 | ||||||||
| Attachments: |
|
||||||||
|
Description
josef radinger
2014-10-12 16:25:30 UTC
Created attachment 946768 [details]
phpci.log
Note: phpCompatInfo version 3.4.0 static analyze results in
/home/extras/SPECS/review/1151855-php-pear-Date-Holidays-
Austria/phpci.log
Created attachment 946770 [details]
review.txt
Generated by fedora-review 0.5.2 (63c24cb) last change: 2014-07-14
[!]: Package must own all directories that it creates.
Note: Directories without known owners:
/usr/share/pear/Date/Holidays/Filter/Austria
[!]: Requires correct, justified where necessary.
=> missing php-date (see phpci.log)
[!]: Each %files section contains %defattr if rpm < 4.4
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
beginning of %install.
[!]: Buildroot is not present
Note: Buildroot: present but not needed
[!]: Package has no %clean section with rm -rf %{buildroot} (or
=> For consistency, if EPEL-5 is planed, add rm -rf ... in %install
if EPEL-5 is not planed, clean the others
[!]: If the source package does not include license text(s) as a separate file
from upstream, the packager SHOULD query upstream to include it.
=> PHP License is mandatory per license term (BSD like).
=> File a upstream bug + add link to this bug
=> You can add the file to the package (link in the headers)
About
# pear.php.net has interesting packaging habits!
%{__tar} -xif %{SOURCE0}
=> This is not a pear habit, but a corrupted archive (known bug with old Archive_Tar version)
=> File a bug upstream and add link in the spec
This is an automatic check from review-stats script. This review request ticket hasn't been updated for some time, but it seems that the review is still being working out by you. If this is right, please respond to this comment clearing the NEEDINFO flag and try to reach out the submitter to proceed with the review. If you're not interested in reviewing this ticket anymore, please clear the fedora-review flag and reset the assignee, so that a new reviewer can take this ticket. Without any reply, this request will shortly be resetted. This is an automatic action taken by review-stats script. The ticket reviewer failed to clear the NEEDINFO flag in a month. As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews we reset the status and the assignee of this ticket. This is an automatic action taken by review-stats script. The ticket submitter failed to clear the NEEDINFO flag in a month. As per https://fedoraproject.org/wiki/Policy_for_stalled_package_reviews we consider this ticket as DEADREVIEW and proceed to close it. |