Bug 1152550
| Summary: | tuned bootloader plugin somehow duplicates cmdline option arguments | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise Linux 7 | Reporter: | Jeremy Eder <jeder> | ||||
| Component: | grubby | Assignee: | Peter Jones <pjones> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Release Test Team <release-test-team-automation> | ||||
| Severity: | urgent | Docs Contact: | |||||
| Priority: | urgent | ||||||
| Version: | 7.1 | CC: | bhu, cdonnell, jeder, jscotka, jskarvad, lcapitulino, mbanas, ovasik, pjones, williams | ||||
| Target Milestone: | rc | ||||||
| Target Release: | --- | ||||||
| Hardware: | All | ||||||
| OS: | Linux | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | grubby-8.28-14.el7 | Doc Type: | Bug Fix | ||||
| Doc Text: |
Cause: grubby was incorrectly treating some grub2 configuration commands with the quoting rules of another command, and then re-assembling the result with a different procedure. This also happened in reverse.
Consequence: Quotes got messed up and some lines that are assignments got duplicated parts.
Fix: grubby's parser was modified to handle these items separately.
Result: Duplicated sections of assignment lines should no longer be generated.
|
Story Points: | --- | ||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2015-11-19 12:55:21 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | |||||||
| Bug Blocks: | 1240765 | ||||||
| Attachments: |
|
||||||
|
Comment 8
Jeremy Eder
2015-07-16 11:51:54 UTC
I tried running stress test on several machines, but it didn't reproduce the problem. Next time you encounter it, please provide content of grub.cfg, content of tuned.conf (or the profile name you used if it wasn't customized), content of the *variables.conf (if utilized) and content of /etc/tuned/bootcmdline. What's the stress test you ran? For me to reproduce this problem is just a matter of installing a new kernel. I've provided full grub.cfg in bug 1152550. I can provide the other files and debug this more later today. (In reply to Luiz Capitulino from comment #10) > What's the stress test you ran? > It was switching profiles and changing the bootcmdline in a loop for couple of minutes. > For me to reproduce this problem is just a matter of installing a new > kernel. > It didn't trigger it for me. I will retry. > I've provided full grub.cfg in bug 1152550. I can provide the other > files and debug this more later today. > Ok, thanks. (In reply to Jaroslav Škarvada from comment #11) > > For me to reproduce this problem is just a matter of installing a new > > kernel. > > > It didn't trigger it for me. I will retry. > I finally reproduced it. That's excellent. I can test a fixed tuned version as soon as you have patches. Created attachment 1054983 [details]
grub.cfg
This is not tuned bug, but bug in grubby - it is crippling the grub.cfg. It may cause other problems, thus it needs to be fixed in grubby.
Version:
grubby-8.28-12.el7.x86_64
Reproducer:
Run the following command on the grub.cfg from the attachment:
# /sbin/grubby --grub2 -c /boot/grub2/grub.cfg --add-kernel=/boot/vmlinuz-3.10.0-297.el7.x86_64 --copy-default --title 'Red Hat Enterprise Linux Server (3.10.0-297.el7.x86_64) 7.2 (Maipo)' '--args=root=/dev/mapper/rhel_hp--dl380pgen8--02--vm--10-root ' '--remove-kernel=TITLE=Red Hat Enterprise Linux Server (3.10.0-297.el7.x86_64) 7.2 (Maipo)' --make-default
Result:
The following from grub.cfg:
set tuned_params="isolcpus=1,3"
is changed by grubby to:
set tuned_params="isolcpus=1,3"=1,3"
Notice the suffix '=1,3"' which shouldn't be added by grubby.
Apologies, Probably should have directed this to BZ#1212128 Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://rhn.redhat.com/errata/RHBA-2015-2110.html |