Bug 1152804

Summary:	Review Request: miniz - Deflate/Inflate compression library with zlib API, ZIP read/write, PNG write
Product:	[Fedora] Fedora	Reporter:	Scott Talbert <swt>
Component:	Package Review	Assignee:	Nobody's working on this, feel free to take it <nobody>
Status:	CLOSED DUPLICATE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	mattdm, package-review, panemade, rc040203
Target Milestone:	---
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-10-15 12:41:07 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Scott Talbert 2014-10-15 02:05:45 UTC

Spec URL: http://www.techie.net/~talbert/miniz.spec
SRPM URL: http://www.techie.net/~talbert/miniz-1.15r4-1.fc20.src.rpm
Description: miniz.c is a lossless, high performance data compression library in a single source file that implements the zlib (RFC 1950) and Deflate (RFC 1951) compressed data format specification standards. It supports the most commonly used functions exported by the zlib library, but is a completely independent implementation so zlib's licensing requirements do not apply. miniz.c also contains simple to use functions for writing .PNG format image files and reading/writing/appending .ZIP format archives. miniz's compression speed has been tuned to be comparable to zlib's, and it also has a specialized real-time compressor function designed to compare well against fastlz/minilzo. 
Fedora Account System Username: swt2c
Koji Scratch Build: http://koji.fedoraproject.org/koji/taskinfo?taskID=7869152

Comment 1 Matthew Miller 2014-10-15 02:42:24 UTC

Please ask upstream to remove the precompiled exe files from the source.

Comment 2 Scott Talbert 2014-10-15 02:55:30 UTC

Done: https://code.google.com/p/miniz/issues/detail?id=40

Comment 3 Matthew Miller 2014-10-15 03:18:46 UTC

And sorry to hit you with things one by one here, but: license should be "Unlicense" -- see https://fedoraproject.org/wiki/Licensing/Unlicense and https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#Software_License_List

Comment 4 Matthew Miller 2014-10-15 03:20:33 UTC

I'm also unsure about including the source .c file in -devel -- that seems out of the ordinary, but seems to be in line with the _intent_ of upstream as a copylib (http://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries#Copylibs)

Comment 5 Scott Talbert 2014-10-15 03:32:07 UTC

(In reply to Matthew Miller from comment #4)
> I'm also unsure about including the source .c file in -devel -- that seems
> out of the ordinary, but seems to be in line with the _intent_ of upstream
> as a copylib
> (http://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries#Copylibs)

Yes, this is certainly out of the ordinary.  :-)  Upstream doesn't provide a separate header file - their intention is for you to #define MINIZ_HEADER_FILE_ONLY and then #include the C file if you want just the header.  Thus I think we have to include the C file in -devel so that we can have other packages link against miniz.

Comment 6 Ralf Corsepius 2014-10-15 06:55:48 UTC

(In reply to Scott Talbert from comment #5)
> (In reply to Matthew Miller from comment #4)
> > I'm also unsure about including the source .c file in -devel -- that seems
> > out of the ordinary, but seems to be in line with the _intent_ of upstream
> > as a copylib
> > (http://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries#Copylibs)
> 
> Yes, this is certainly out of the ordinary.  :-) 
Well, I guess upstream is not aware about the fact, bundling zlib is THE historic precedence for banning static linkage and generally consider bundling to be a crap design.

That said, I regret not to be able to have negative feelings on this package. In short, I feel this package should not be included into Fedora.

Comment 7 Ralf Corsepius 2014-10-15 06:56:59 UTC

(In reply to Ralf Corsepius from comment #6)

> That said, I regret not to be able to have negative feelings on this
> package. In short, I feel this package should not be included into Fedora.
Sorry, typo: ... I regret not to be able to deny negative feelings ...

Comment 8 Parag AN(पराग) 2014-10-15 07:02:18 UTC

this package already submitted for review by Petr just a day before. Please communicate with him. His submission is https://bugzilla.redhat.com/show_bug.cgi?id=1152653

Comment 9 Scott Talbert 2014-10-15 12:41:07 UTC

Thanks all for the feedback.  Since Petr beat me by about 150 bugs, I'll close mine and let him have this one.  :-)  In his packaging, he has extracted a header file from the C file, so I think that might address Ralf's concerns about allowing static linking.

*** This bug has been marked as a duplicate of bug 1152653 ***

Comment 10 Matthew Miller 2014-10-15 13:27:51 UTC

Heh, I was going to make the suggestion of pulling out a .h file — that encourages people to use it as a shared library (and, prevents it from being compiled in by accident).