Bug 1153964
| Summary: | quota: rename of "dir" fails in case of quota space availability is around 1GB | ||
|---|---|---|---|
| Product: | [Community] GlusterFS | Reporter: | Vijaikumar Mallikarjuna <vmallika> |
| Component: | quota | Assignee: | Raghavendra G <rgowdapp> |
| Status: | CLOSED CURRENTRELEASE | QA Contact: | |
| Severity: | high | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | mainline | CC: | bugs, hgowtham, smohan, storage-qa-internal |
| Target Milestone: | --- | ||
| Target Release: | --- | ||
| Hardware: | x86_64 | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | Doc Type: | Bug Fix | |
| Doc Text: | Story Points: | --- | |
| Clone Of: | 1139104 | Environment: | |
| Last Closed: | 2018-11-21 02:53:58 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | 1139104, 1177592 | ||
| Bug Blocks: | |||
|
Comment 1
Anand Avati
2014-10-17 08:20:54 UTC
REVIEW: http://review.gluster.org/8940 (quota: For a rename operation do do quota_check_limit only till the common ancestor of src and dst file) posted (#2) for review on master by Vijaikumar Mallikarjuna (vmallika) REVIEW: http://review.gluster.org/8940 (quota: For a rename operation do do quota_check_limit only till the common ancestor of src and dst file) posted (#3) for review on master by Vijaikumar Mallikarjuna (vmallika) REVIEW: http://review.gluster.org/8940 (quota: For a rename operation do do quota_check_limit only till the common ancestor of src and dst file) posted (#4) for review on master by Vijaikumar Mallikarjuna (vmallika) REVIEW: http://review.gluster.org/8940 (quota: For a rename operation do do quota_check_limit only till the common ancestor of src and dst file) posted (#5) for review on master by Vijaikumar Mallikarjuna (vmallika) REVIEW: http://review.gluster.org/8940 (quota: For a rename operation do do quota_check_limit only till the common ancestor of src and dst file) posted (#6) for review on master by Vijaikumar Mallikarjuna (vmallika) REVIEW: http://review.gluster.org/8940 (quota: For a rename operation do do quota_check_limit only till the common ancestor of src and dst file) posted (#7) for review on master by Vijaikumar Mallikarjuna (vmallika) REVIEW: http://review.gluster.org/9293 (quota: No need for quota-limit check if rename is under same parent) posted (#1) for review on master by venkatesh somyajulu (vsomyaju) REVIEW: http://review.gluster.org/8940 (quota: For a rename operation do do quota_check_limit only till the common ancestor of src and dst file) posted (#8) for review on master by Vijaikumar Mallikarjuna (vmallika) REVIEW: http://review.gluster.org/8940 (quota: For a rename operation do do quota_check_limit only till the common ancestor of src and dst file) posted (#9) for review on master by Vijaikumar Mallikarjuna (vmallika) REVIEW: http://review.gluster.org/8940 (quota: For a rename operation do do quota_check_limit only till the common ancestor of src and dst file) posted (#10) for review on master by Vijaikumar Mallikarjuna (vmallika) REVIEW: http://review.gluster.org/8940 (quota: For a rename operation, do quota_check_limit only till the common ancestor of src and dst file) posted (#11) for review on master by Vijaikumar Mallikarjuna (vmallika) REVIEW: http://review.gluster.org/8940 (quota: For a rename operation, do quota_check_limit only till the common ancestor of src and dst file) posted (#12) for review on master by Vijaikumar Mallikarjuna (vmallika) REVIEW: http://review.gluster.org/8940 (quota: For a rename operation, do quota_check_limit only till the common ancestor of src and dst file) posted (#13) for review on master by Vijaikumar Mallikarjuna (vmallika) REVIEW: http://review.gluster.org/8940 (quota: For a rename operation, do quota_check_limit only till the common ancestor of src and dst file) posted (#14) for review on master by Vijaikumar Mallikarjuna (vmallika) REVIEW: http://review.gluster.org/8940 (quota: For a rename operation, do quota_check_limit only till the common ancestor of src and dst file) posted (#15) for review on master by Vijaikumar Mallikarjuna (vmallika) REVIEW: http://review.gluster.org/8940 (quota: For a rename operation, do quota_check_limit only till the common ancestor of src and dst file) posted (#16) for review on master by Vijaikumar Mallikarjuna (vmallika) REVIEW: http://review.gluster.org/8940 (quota: For a rename operation, do quota_check_limit only till the common ancestor of src and dst file) posted (#17) for review on master by Vijaikumar Mallikarjuna (vmallika) REVIEW: http://review.gluster.org/8940 (quota: For a rename operation, do quota_check_limit only till the common ancestor of src and dst file) posted (#18) for review on master by Vijaikumar Mallikarjuna (vmallika) COMMIT: http://review.gluster.org/8940 committed in master by Raghavendra G (rgowdapp) ------ commit b6ea761969f85fbb0f22810eb3a3bf1476c8792c Author: vmallika <vmallika> Date: Wed Dec 24 15:13:36 2014 +0530 quota: For a rename operation, do quota_check_limit only till the common ancestor of src and dst file Example: set quota limit set to 1GB on / create a file /a1/b1/file1 of 600MB mv /a1/b1/file1 /a1/b1/file2 This rename fails as it takes delta into account which sums up to 1.2BG. Though we are not creating new file, we still get quota exceeded error. So quota enforce should happen only till b1. Similarly: mv /a/b/c/file /a/b/x/y/file quota enforce should happen only till dir 'b' Change-Id: Ia1e5363da876c3d71bd424e67a8bb28b7ac1c7c1 BUG: 1153964 Signed-off-by: vmallika <vmallika> Reviewed-on: http://review.gluster.org/8940 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Raghavendra G <rgowdapp> Tested-by: Raghavendra G <rgowdapp> REVIEW: http://review.gluster.org/9419 (quota: For a rename operation, do quota_check_limit only till the common ancestor of src and dst file) posted (#1) for review on master by Vijaikumar Mallikarjuna (vmallika) REVIEW: http://review.gluster.org/9419 (quota: For a link operation, do quota_check_limit only till the common ancestor of src and dst file) posted (#2) for review on master by Vijaikumar Mallikarjuna (vmallika) REVIEW: http://review.gluster.org/9419 (quota: For a link operation, do quota_check_limit only till the common ancestor of src and dst file) posted (#3) for review on master by Vijaikumar Mallikarjuna (vmallika) REVIEW: http://review.gluster.org/9419 (quota: For a link operation, do quota_check_limit only till the common ancestor of src and dst file) posted (#4) for review on master by Vijaikumar Mallikarjuna (vmallika) REVIEW: http://review.gluster.org/9419 (quota: For a link operation, do quota_check_limit only till the common ancestor of src and dst file) posted (#5) for review on master by Vijaikumar Mallikarjuna (vmallika) COMMIT: http://review.gluster.org/9419 committed in master by Raghavendra G (rgowdapp) ------ commit 8d73f6288249757662cf36e746835e3ecd84add1 Author: vmallika <vmallika> Date: Thu Jan 8 16:03:04 2015 +0530 quota: For a link operation, do quota_check_limit only till the common ancestor of src and dst file In a dht_rename, if src_cached and dst_hashed are different, then rename is split into link and unlink. We need to handle quota_link properly. We have fixed quota_rename in patch# 8940, we need to handle quota_link similarly > http://review.gluster.org/#/c/8940/ > quota: For a rename operation, do quota_check_limit only till the > common ancestor of src and dst file > Example: > set quota limit set to 1GB on / > create a file /a1/b1/file1 of 600MB > mv /a1/b1/file1 /a1/b1/file2 > This rename fails as it takes delta into account which sums up to 1.2BG. > Though we are not creating new file, we still get quota exceeded error. > So quota enforce should happen only till b1. > Similarly: > mv /a/b/c/file /a/b/x/y/file > quota enforce should happen only till dir 'b' > Change-Id: Ia1e5363da876c3d71bd424e67a8bb28b7ac1c7c1 > BUG: 1153964 > Signed-off-by: vmallika <vmallika> > Reviewed-on: http://review.gluster.org/8940 > Tested-by: Gluster Build System <jenkins.com> > Reviewed-by: Raghavendra G <rgowdapp> > Tested-by: Raghavendra G <rgowdapp> Change-Id: I2c814018d17f7af1807c1d1d162d8bdcbb31e491 BUG: 1153964 Signed-off-by: vmallika <vmallika> Reviewed-on: http://review.gluster.org/9419 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Raghavendra G <rgowdapp> Tested-by: Raghavendra G <rgowdapp> |