Bug 1154163
Summary: | Review Request: libmozjpeg - SIMD-accelerated JPEG codec that provides both the libjpeg and TurboJPEG APIs | ||
---|---|---|---|
Product: | [Fedora] Fedora | Reporter: | Rahul Sundaram <metherid> |
Component: | Package Review | Assignee: | Denis Fateyev <denis> |
Status: | CLOSED NOTABUG | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
Severity: | medium | Docs Contact: | |
Priority: | medium | ||
Version: | rawhide | CC: | denis, kevin, musuruan, package-review |
Target Milestone: | --- | Flags: | denis:
fedora-review?
|
Target Release: | --- | ||
Hardware: | All | ||
OS: | Linux | ||
Whiteboard: | |||
Fixed In Version: | Doc Type: | Bug Fix | |
Doc Text: | Story Points: | --- | |
Clone Of: | Environment: | ||
Last Closed: | 2014-11-21 18:53:56 UTC | Type: | --- |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: |
Description
Rahul Sundaram
2014-10-17 17:25:17 UTC
Second scratch build http://koji.fedoraproject.org/koji/taskinfo?taskID=7899282 Had to disable the tests because it hung indefinitely. rpmlint: Checking: libmozjpeg-2.1-1.fc21.x86_64.rpm libmozjpeg-utils-2.1-1.fc21.x86_64.rpm libmozjpeg-devel-2.1-1.fc21.x86_64.rpm libmozjpeg-2.1-1.fc21.src.rpm libmozjpeg.x86_64: W: spelling-error Summary(en_US) codec -> codex, code, codes libmozjpeg.x86_64: W: spelling-error Summary(en_US) libjpeg -> libel libmozjpeg.x86_64: W: spelling-error %description -l en_US codec -> codex, code, codes libmozjpeg.x86_64: W: spelling-error %description -l en_US libjpeg -> libel libmozjpeg.x86_64: W: spelling-error %description -l en_US codecs -> codes, coders, code's libmozjpeg.x86_64: W: spelling-error %description -l en_US colorspace -> color space, color-space, colors pace libmozjpeg.x86_64: W: spelling-error %description -l en_US endian -> Indian, Dianne, Diane libmozjpeg.x86_64: W: shared-lib-calls-exit /usr/lib64/libturbojpeg.so.0.1.0 exit.5 libmozjpeg.x86_64: W: shared-lib-calls-exit /usr/lib64/libjpeg.so.62.1.0 exit.5 libmozjpeg-utils.x86_64: W: spelling-error %description -l en_US libjpeg -> libel libmozjpeg-utils.x86_64: W: spelling-error %description -l en_US Cjpeg -> Peg libmozjpeg-utils.x86_64: W: spelling-error %description -l en_US Djpeg -> Pegged libmozjpeg-utils.x86_64: W: spelling-error %description -l en_US Jpegtran -> Registrant libmozjpeg-utils.x86_64: W: spelling-error %description -l en_US Rdjpgcom libmozjpeg-utils.x86_64: W: spelling-error %description -l en_US Wrjpgcom libmozjpeg-utils.x86_64: W: no-manual-page-for-binary tjbench libmozjpeg-devel.x86_64: W: only-non-binary-in-usr-lib libmozjpeg.src: W: spelling-error Summary(en_US) codec -> codex, code, codes libmozjpeg.src: W: spelling-error Summary(en_US) libjpeg -> libel libmozjpeg.src: W: spelling-error %description -l en_US codec -> codex, code, codes libmozjpeg.src: W: spelling-error %description -l en_US libjpeg -> libel libmozjpeg.src: W: spelling-error %description -l en_US codecs -> codes, coders, code's libmozjpeg.src: W: spelling-error %description -l en_US colorspace -> color space, color-space, colors pace libmozjpeg.src: W: spelling-error %description -l en_US endian -> Indian, Dianne, Diane 4 packages and 0 specfiles checked; 0 errors, 24 warnings. Source checksums ---------------- https://github.com/mozilla/mozjpeg/archive/v2.1.tar.gz : CHECKSUM(SHA256) this package : f3d5413a5fc94990994e1cb9c8817e47f8508f5a4ae3c124628e309d1873bec3 CHECKSUM(SHA256) upstream package : f3d5413a5fc94990994e1cb9c8817e47f8508f5a4ae3c124628e309d1873bec3 Additional note, currently libmozjpeg has an explicit conflict with libjpeg-turbo, however this will be fixed in the future when upstream documents ABI compatibility with the latter https://github.com/mozilla/mozjpeg/issues/21 https://github.com/mozilla/mozjpeg/issues/67 Utils package description is wrong. It refers to libjpeg-turbo and not to libmozjpeg. fixed A Conflicts with a core system library against which half of Fedora is linked is not acceptable. This can only go in if API compatibility is guaranteed (or the soname is bumped, but then it would lose soname compatibility with libjpeg 6.2, which would suck) and the Conflicts changed to an Obsoletes. > This can only go in if API compatibility is guaranteed (or the soname is
> bumped, but then it would lose soname compatibility with libjpeg 6.2, which
> would suck)
… or if they follow through with their plans of renaming the library altogether, in which case it would just be a separate library from libjpeg(-turbo) and neither Conflict with nor Obsolete libjpeg-turbo. (Only symbol conflicts could be an issue in that case.)
(In reply to Kevin Kofler from comment #8) > if they follow through with their plans of renaming the library > altogether, in which case it would just be a separate library from > libjpeg(-turbo) and neither Conflict with nor Obsolete libjpeg-turbo. That would be the best approach here. Although I doubt they would rename the library. Considering all that above said I think the package cannot be accepted in its current state. Will revisit this if situation changes. |