Bug 1155009

Summary: Validation failure while editing host in production only environment
Product: Red Hat OpenStack Reporter: Imre Farkas <ifarkas>
Component: foremanAssignee: Mike Burns <mburns>
Status: CLOSED ERRATA QA Contact: Ami Jeain <ajeain>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 5.0 (RHEL 6)CC: athomas, ddomingo, mburns, rhos-maint, sasha, yeylon
Target Milestone: z2Keywords: ZStream
Target Release: Installer   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: foreman-1.6.0.44-6.el6ost Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-11-04 17:03:45 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Imre Farkas 2014-10-21 08:56:54 UTC
Description of problem:
A "Please fill out this field." message appears around the browser without any help what is actually missing.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1. Go to hosts#edit
2. Submit the form

Actual results:
"Please fill out this field." message appears.

Expected results:
The form should be submitted without any validation failure.


Additional info:

Comment 1 Imre Farkas 2014-10-21 08:58:41 UTC
I suspect that the following commit is missing from rhelosp-foreman:

commit 22438bd257ba586e92ecbccc8382511dabddbe26
Author: Marek Hulan <mhulan>
Date:   Fri Sep 26 10:24:36 2014 +0200

    Fixes #7750 - hidden required fields do not prevent submit
    
    When a field is explicitly required an HTML5 tag required was added
    which caused issues during form submit.

Comment 4 Mike Burns 2014-10-21 12:28:26 UTC
the patch in comment 1 also requires:

commit 3b87444aac04cf78e073bcb6e7f7778ef72f9c8e
Author: Marek Hulan <mhulan>
Date:   Tue Sep 16 11:09:12 2014 +0200

    Fixes #7450 - do not mark non-required fields
    
    If validation is conditional we don't mark fields as required by
    default. Also fixes disabling by override using :required option.

which requires:

commit 2af7c64a3b9c2699a3131483bc2344b50c138542
Author: Joseph Magen <jmagen>
Date:   Thu Jun 26 11:11:31 2014 +0300

    Fixes #6400 - Show * next to required form fields


---

backporting all 3 to foreman

Comment 6 Alexander Chuzhoy 2014-10-21 14:25:34 UTC
Verified:
openstack-puppet-modules-2014.1-24.el6ost.noarch
rhel-osp-installer-0.4.5-1.el6ost.noarch
ruby193-rubygem-foreman_openstack_simplify-0.0.6-8.el6ost.noarch
openstack-foreman-installer-2.0.30-1.el6ost.noarch
ruby193-rubygem-staypuft-0.4.7-1.el6ost.noarch

Doesn't reproduce now.

Comment 10 errata-xmlrpc 2014-11-04 17:03:45 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2014-1800.html