Bug 1155129

Fix from spacewalk master backported to CLIENT-RHEL-6 as
commit aac9b121a54ec549cc95956c96c594238b30bf94
    err variable needs to be initialized before assignment

Verified with yum-rhn-plugin-0.9.1-54.el6

Reproducer:

0) package yum-rhn-plugin-0.9.1-50.el6.noarch
1) register system to satellite
2) install package spacewalk-koan
3) create virtual guest by satellite webui
4) run rhn_check -vv


# tail /var/log/up2date
[Wed Mar 11 08:57:32 2015] up2date 
Traceback (most recent call last):
  File "/usr/sbin/rhn_check", line 342, in __run_action
    (status, message, data) = CheckCli.__do_call(method, params, kwargs)
  File "/usr/sbin/rhn_check", line 335, in __do_call
    retval = method(*params, **kwargs)
  File "/usr/share/rhn/actions/packages.py", line 369, in update
    if err:
<type 'exceptions.UnboundLocalError'>: local variable 'err' referenced before assignment

[Wed Mar 11 08:57:32 2015] up2date D: Sending back response((6,), 'Fatal error in Python code occured', {})

Regression with newer package than yum-rhn-plugin-0.9.1-52.el6_6.noarch. Provisioning does not work and I get error "Error while executing packages action:
empty transaction"


# rhn_check -vv
D: check_action{'action': "<?xml
version='1.0'?>\n<methodCall>\n<methodName>packages.update</methodName>\n<params>\n<param>\n<value><array><data>\n<value><array><data>\n<value><string>spacewalk-koan</string></value>\n<value><string>2.3.0}

updateLoginInfo() login info
D: login(forceUpdate=True) invoked
logging into up2date server
D: rpcServer: Calling XMLRPC up2date.login
D: writeCachedLogin() invoked
D: Wrote pickled loginInfo at 1430742096.0 with expiration of
1430745696.0 seconds.
successfully retrieved authentication token from up2date server
D: logininfo:{'X-RHN-Server-Id': 1000011042, 'X-RHN-Auth-Server-Time':
'1430741966.73', 'X-RHN-Auth':
'fhd3Meu4dmOXcWN5aWoZ3EdoLBa0F5xGKr9DCe6RsAM=', 'X-RHN-Auth-Channels':
[['rhel-x86_64-server-6', '20150503011355', '1', '1'], ['rhn-too}
D: handle_action{'action': "<?xml
version='1.0'?>\n<methodCall>\n<methodName>packages.update</methodName>\n<params>\n<param>\n<value><array><data>\n<value><array><data>\n<value><string>spacewalk-koan</string></value>\n<value><string>2.3.}

D: handle_action actionid = 9434, version = 2
D: do_call packages.update([['spacewalk-koan', '2.3.0', '2.el6sat', '',
'noarch']],){'cache_only': None}
Loaded plugins: product-id, rhnplugin
D: rpcServer: Calling XMLRPC up2date.listChannels
This system is receiving updates from RHN Classic or RHN Satellite.
D: Called update[['spacewalk-koan', '2.3.0', '2.el6sat', '', 'noarch']]
Package spacewalk-koan-2.3.0-2.el6sat.noarch already installed and
latest version
0 0
D: Sending back response((6,), 'Error while executing packages action:
empty transaction', {})
D: do_call packages.checkNeedUpdate('rhnsd=1',){}
D: local action status: (0, 'rpm database not modified since last update
(or package list recently updated)', {})
D: rpcServer: Calling XMLRPC registration.welcome_message


Satellite tried to update spacewalk-koan, but update is not available.
And action end with errot "empty transaction"

----
D: check_action{'action': "<?xml
version='1.0'?>\n<methodCall>\n<methodName>packages.update</methodName>\n<params>\n<param>\n<value><array><data>\n<value><array><data>\n<value><string>spacewalk-koan</string></value>\n<value><string>2.3.0}

updateLoginInfo() login info

----
D: Sending back response((6,), 'Error while executing packages action:
empty transaction', {})
----

# yum check-update
Loaded plugins: product-id, rhnplugin, security, subscription-manager
This system is receiving updates from RHN Classic or RHN Satellite.


# rpm -qf /usr/share/rhn/actions/packages.py
yum-rhn-plugin-0.9.1-57.el6.noarch

# yum info spacewalk-koan
Loaded plugins: product-id, rhnplugin, security, subscription-manager
This system is receiving updates from RHN Classic or RHN Satellite.
Installed Packages
Name        : spacewalk-koan
Arch        : noarch
Version     : 2.3.0
Release     : 2.el6sat
Size        : 60 k
Repo        : installed
 From repo   : rhn-tools-rhel-x86_64-server-6
Summary     : Support package for spacewalk koan interaction
URL         : https://fedorahosted.org/spacewalk
License     : GPLv2
Description : Support package for spacewalk koan interaction.


code:
             yum_base.doLock(YUM_PID_FILE)
             # Accumulate transaction data
             oldcount = len(yum_base.tsInfo)
-->>
        if not len(yum_base.tsInfo) > oldcount:

# note: result is "not 0 > 0":

             raise yum.Errors.YumBaseError, 'empty transaction'
-->>
             # depSolving stage
             (result, resultmsgs) = yum_base.buildTransaction()

This FAILS_QA in comment 12 should be reported against bug 1183989 instead. Same symptom as this original bug, but different cause. Moving, please mark this bug as VALIDATED again.

Verified with yum-rhn-plugin-0.9.1-58.el6.noarch

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2015-1390.html