Bug 1155240

Summary:	Review Request: gr-rds - GNU Radio FM RDS Receiver
Product:	[Fedora] Fedora	Reporter:	Dan Horák <dan>
Component:	Package Review	Assignee:	Jaroslav Škarvada <jskarvad>
Status:	CLOSED ERRATA	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	rawhide	CC:	jskarvad, package-review
Target Milestone:	---	Flags:	jskarvad: fedora-review+ gwync: fedora-cvs+
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	gr-rds-0-0.6.20141117gitff1ca15.fc21	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-11-20 21:58:08 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Dan Horák 2014-10-21 16:45:49 UTC

Spec URL: http://fedora.danny.cz/gr-rds.spec
SRPM URL: http://fedora.danny.cz/gr-rds-0-0.2.20141006git841b6307.fc21.src.rpm
Description: GNU Radio FM RDS Receiver
Fedora Account System Username: sharkcz

Comment 1 Jaroslav Škarvada 2014-10-22 10:23:59 UTC

Review:
- you could install utils to e.g. /usr/share/gr-rds

- you should create doc and devel subackages (you can copy&paste this from e.g. gr-iqbal or other gr-* spec files)

- it's GPLv2+ or GPLv3+. I am able to find there GPLv3+ licensed code/scripts snips from gnuradio, thus the final package should be probably licensed under GPLv3+. If unsure, you can consult this with upstream.

- no macros in comments, e.g. %{name} and more, please escape them with %, i.e. %%{name}

- non-executable-script /usr/lib64/python2.7/site-packages/rds/rdspanel.py 0644L /usr/bin/env
  please filter out the hashbangs for python libs under site-packages

- incorrect-fsf-address in /usr/include/rds/gnuradio/rds/data_encoder.h and in more files
  please notify upstream to correct the address

- there is library, you need to run /sbin/ldconfig in %post and %postun

- invalid-url Source0: gr-rds-20141006git841b6307.tar.xz
  please add URL from packaging guidelines [1] (you can copy&paste this from e.g. gr-fcdproplus package)

- unused-direct-shlib-dependency /usr/lib64/libgnuradio-rds-0.1.1git.so.0.0.0 /lib64/libboost_filesystem.so.1.54.0
  please link with -Wl,--as-needed

[1] https://fedoraproject.org/wiki/Packaging:SourceURL?rd=Packaging/SourceURL#Github

Comment 2 Dan Horák 2014-11-17 20:12:51 UTC

Updated spec URL: http://fedora.danny.cz/gr-rds.spec
Updated SRPM URL: http://fedora.danny.cz/gr-rds-0-0.3.20141024gitc3b1c31.fc21.src.rpm

* Sat Nov 15 2014 Dan Horák <dan> - 0-0.3.20141024gitc3b1c31
- switched to standard github Source
- added docs and devel subpackages
- fix issues from review

All issues were reported to upstream in form of a pull request - https://github.com/bastibl/gr-rds/pull/5

Comment 3 Jaroslav Škarvada 2014-11-20 14:33:02 UTC

Looks good, approving.

Comment 4 Dan Horák 2014-11-20 15:05:49 UTC

New Package SCM Request
=======================
Package Name: gr-rds
Short Description: GNU Radio FM RDS Receiver
Upstream URL: https://github.com/bastibl/gr-rds
Owners: sharkcz jskarvad
Branches: f20 f21 epel7

Comment 5 Gwyn Ciesla 2014-11-20 15:28:48 UTC

Git done (by process-git-requests).

Comment 6 Dan Horák 2014-11-20 21:58:08 UTC

imported and built

Comment 7 Fedora Update System 2014-11-24 12:10:59 UTC

gr-rds-0-0.5.20141117gitff1ca15.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/FEDORA-2014-15581/gr-rds-0-0.5.20141117gitff1ca15.fc21

Comment 8 Fedora Update System 2015-04-21 18:58:17 UTC

gr-rds-0-0.6.20141117gitff1ca15.fc21 has been pushed to the Fedora 21 stable repository.