Bug 1155347

Summary:	Should prompt correct and important parameter information when use none or error parameter in "rhc server add" command
Product:	OpenShift Online	Reporter:	Luke Meyer <lmeyer>
Component:	oc	Assignee:	Fabiano Franz <ffranz>
Status:	CLOSED WONTFIX	QA Contact:	libra bugs <libra-bugs>
Severity:	low	Docs Contact:
Priority:	medium
Version:	2.x	CC:	bleanhar, jialiu, jokerman, libra-bugs, libra-onpremise-devel, mmasters, mmccomas, rthrashe, sztsian, xtian, yanpzhan
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	1155003	Environment:
Last Closed:	2017-05-31 18:22:11 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1155003

Comment 1 Zamir SUN 2014-11-04 12:17:42 UTC

PR https://github.com/openshift/rhc/pull/659
I am not sure what Wang Yanyan meant by the first point in Expected Results of bz1155347. I've fixed the second point which I thinks is more important to check

Comment 2 Zamir SUN 2014-11-04 12:18:30 UTC

(In reply to Zamir SUN from comment #1)
> of bz1155347. I've fixed the second point which I thinks is more important

Typo, I mean bz1155003

Comment 3 wangyanyan 2014-11-12 08:12:14 UTC

(In reply to Zamir SUN from comment #2)
> (In reply to Zamir SUN from comment #1)
> > of bz1155347. I've fixed the second point which I thinks is more important
> 
> Typo, I mean bz1155003

First point is :
When user run "rhc server add", show the help below :
# rhc server add
Missing required argument 'hostname'.
Usage: rhc server-add <hostname> [<nickname>] [--rhlogin LOGIN]
[--[no-]use-authorization-tokens] [--[no-]insecure] [--use] [--skip-wizard]
[--timeout SECONDS] [--ssl-ca-file FILE] [--ssl-client-cert-file FILE] [--sol-client-key-file FILE] [--ssl-version VERSION]
Pass '--help' to see the full list of options

Now miss [--sol-client-key-file FILE] parameter

Comment 4 Zamir SUN 2014-11-12 08:37:15 UTC

(In reply to wangyanyan from comment #3)
> (In reply to Zamir SUN from comment #2)
> > (In reply to Zamir SUN from comment #1)
> 
> Now miss [--sol-client-key-file FILE] parameter
Thanks for your reply.
Updated to the PR.

Comment 6 Rory Thrasher 2015-12-21 20:36:32 UTC

*** Bug 1155345 has been marked as a duplicate of this bug. ***

Comment 7 Yanping Zhang 2015-12-25 05:35:03 UTC

Tested on devenv_5745, the bug has been fixed.
Steps to test:
1. Check the help info for server add, there is option --ssl-client-key-file :
#rhc server add -h
--ssl-client-key-file     An RSA client certificate key
2.When providing 1 or 2 options of the 3 options:--ssl-ca-file, --ssl-client-cert-file, and --ssl-client-key-file , there will be error info explaining that all three are required.
2.1 # rhc server add ip-172-18-13-246 --ssl-ca-file /tmp/ca.crt 
You must use the --ssl-ca-file, --ssl-client-cert-file, and --ssl-client-key-file commands together.
Usage: rhc server-add <hostname> [<nickname>] [--rhlogin LOGIN] [--[no-]use-authorization-tokens] [--[no-]insecure] [--use]
[--skip-wizard] [--timeout SECONDS] [--ssl-ca-file FILE] [--ssl-client-cert-file FILE] [--ssl-client-key-file FILE] [--ssl-version
VERSION]
Pass '--help' to see the full list of options

2.2 # rhc server add ip-172-18-13-246 --ssl-ca-file /tmp/ca.crt --ssl-client-cert-file /tmp/ca1.crt
You must use the --ssl-ca-file, --ssl-client-cert-file, and --ssl-client-key-file commands together.
Usage: rhc server-add <hostname> [<nickname>] [--rhlogin LOGIN] [--[no-]use-authorization-tokens] [--[no-]insecure] [--use]
[--skip-wizard] [--timeout SECONDS] [--ssl-ca-file FILE] [--ssl-client-cert-file FILE] [--ssl-client-key-file FILE] [--ssl-version
VERSION]
Pass '--help' to see the full list of options

2.3 # rhc server add ip-172-18-13-246 --ssl-ca-file /tmp/ca.crt --ssl-client-key-file .ssh/id_rsa
You must use the --ssl-ca-file, --ssl-client-cert-file, and --ssl-client-key-file commands together.
Usage: rhc server-add <hostname> [<nickname>] [--rhlogin LOGIN] [--[no-]use-authorization-tokens] [--[no-]insecure] [--use]
[--skip-wizard] [--timeout SECONDS] [--ssl-ca-file FILE] [--ssl-client-cert-file FILE] [--ssl-client-key-file FILE] [--ssl-version
VERSION]
Pass '--help' to see the full list of options

Comment 8 Eric Paris 2017-05-31 18:22:11 UTC

We apologize, however, we do not plan to address this report at this time. The majority of our active development is for the v3 version of OpenShift. If you would like for Red Hat to reconsider this decision, please reach out to your support representative. We are very sorry for any inconvenience this may cause.