Bug 1155540
| Summary: | Raise error or shutdown broker when --sasl-config is invalid path | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | Red Hat Enterprise MRG | Reporter: | Pavel Moravec <pmoravec> | ||||||
| Component: | qpid-cpp | Assignee: | Ernie <eallen> | ||||||
| Status: | CLOSED ERRATA | QA Contact: | Eric Sammons <esammons> | ||||||
| Severity: | low | Docs Contact: | |||||||
| Priority: | medium | ||||||||
| Version: | 3.0 | CC: | esammons, iboverma, jross, pematous, zkraus | ||||||
| Target Milestone: | 3.2 | Keywords: | Improvement, Patch | ||||||
| Target Release: | --- | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | qpid-cpp-0.32-1 | Doc Type: | Enhancement | ||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2015-10-08 13:09:38 UTC | Type: | Bug | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Attachments: |
|
||||||||
|
Description
Pavel Moravec
2014-10-22 10:40:41 UTC
For steps 1 and 2 in comment #0, the directory and file exist. The problem is with the contents of the file. A typical sasl qpidd.conf looks like: pwcheck_method: auxprop auxprop_plugin: sasldb sasldb_path: /usr/local/etc/qpid/sasl_config/qpidd.sasldb sql_select: dummy select mech_list: ANONYMOUS PLAIN DIGEST-MD5 EXTERNAL CRAM-MD5 If we are now going to parse the content of that file, which lines should we validate? We don't want to parse the contents at all. We should only attempt to cover case number 3, imo. Created attachment 952565 [details]
Add various tests on the passed in directory
The patch adds the following tests:
That what is passed in is a directory and not a file
That the directory contains a qpidd.conf file
That the broker is able to read the qpidd.conf file
Patch has been reviewed.
Currently the windows sasl implementation does not use the --sasl-config option and so is not affected by this bz and patch. Created attachment 957261 [details]
Fixes build problem
Prevents the broker from failing to start if an empty saslConfig directory is used.
This issue is fixed. Checked on RHEL 6 x86_64 and i386 with packages: qpid-cpp-client-0.34-1.el6 qpid-cpp-server-rdma-0.34-1.el6 qpid-cpp-server-ha-0.34-1.el6 qpid-proton-c-0.9-4.el6 qpid-cpp-server-0.34-1.el6 qpid-cpp-client-devel-0.34-1.el6 qpid-cpp-server-linearstore-0.34-1.el6 qpid-cpp-server-devel-0.34-1.el6 qpid-qmf-0.34-1.el6 qpid-cpp-client-rdma-0.34-1.el6 qpid-cpp-server-xml-0.34-1.el6 qpid-cpp-debuginfo-0.34-1.el6 and qpid-cpp-client-rdma-0.32-1.el6 qpid-cpp-debuginfo-0.32-1.el6 qpid-proton-c-0.9-4.el6 qpid-cpp-server-0.32-1.el6 qpid-cpp-client-devel-0.32-1.el6 qpid-cpp-server-rdma-0.32-1.el6 qpid-cpp-server-xml-0.32-1.el6 qpid-cpp-server-linearstore-0.32-1.el6 qpid-cpp-client-0.32-1.el6 qpid-cpp-server-devel-0.32-1.el6 qpid-cpp-server-ha-0.32-1.el6 Broker does not start in both versions in steps 2., 3. and 4. and gives an error message, which is OK. -> VERIFIED Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://rhn.redhat.com/errata/RHEA-2015-1879.html |