Bug 1155799

Summary:	Irqbalance didn't log failing to set SMP affinity
Product:	Red Hat Enterprise Linux 7	Reporter:	Andrej Manduch <amanduch>
Component:	irqbalance	Assignee:	Petr Holasek <pholasek>
Status:	CLOSED ERRATA	QA Contact:	Andrej Manduch <amanduch>
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	7.1	CC:	dhoward, emcnabb, jeder, jsvarova, pholasek
Target Milestone:	rc
Target Release:	---
Hardware:	All
OS:	Linux
Whiteboard:
Fixed In Version:	irqbalance-1.0.7-2.el7	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	1152188	Environment:
Last Closed:	2015-11-19 05:21:22 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1152188
Bug Blocks:

Description Andrej Manduch 2014-10-22 20:43:06 UTC

+++ This bug was initially created as a clone of Bug #1152188 +++

Description of problem:

If irqbalance doesn't have right to change irq smp affinity it will silliently continue without any warning in logs what so ever.

How reproducible:

Run irqbalance with 

Steps to Reproduce:
1. log yourself as regular user
2. set IRQBALANCE_BANNED_CPUS
3. run irqbalancer
4. check /proc/irq/*/smp_affinity if was changed by irqbalance to value coresponding with IRQBALANCE_BANNED_CPUS (if you've done everything right value should stay unchanged due lack of privileges)
5. check irqbalance log (you'll see nothing about failing to set SMP affinity)

Expected results:

I belive I should be able to at least see some warning in logs about failing to set SMP affinity

Additional info:
In attachment I'm sending output from my run of `strace -e trace=file irqbalance --debug --oneshot`

--- Additional comment from RHEL Product and Program Management on 2014-10-15 05:40:35 EDT ---

Since this bug report was entered in bugzilla, the release flag has been
set to ? to ensure that it is properly evaluated for this release.

Comment 2 Petr Holasek 2014-12-10 14:58:12 UTC

Hi Andrej,

What is use case of using irqbalance as regular user? I would rather make irqbalance writing warning at the startup if it wasn't executed under root account.

Comment 3 Andrej Manduch 2014-12-15 09:25:04 UTC

(In reply to Petr Holasek from comment #2)
> Hi Andrej,
> 
> What is use case of using irqbalance as regular user? I would rather make
> irqbalance writing warning at the startup if it wasn't executed under root
> account.

I mentioned run as a regular user only to way to reproduce this. When I reported this I had in mind maybe some security module in kernel or whatever what sysadmin can get easilly miss when he will not see warning in log.
Or in some irq you don't have right to change smp affinity by nature of the interrupt.

Comment 8 errata-xmlrpc 2015-11-19 05:21:22 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2015-2207.html