Bug 1155955

Summary: Missing addon results in a traceback when %addon header options are specified
Product: Red Hat Enterprise Linux 7 Reporter: Martin Kolman <mkolman>
Component: anacondaAssignee: Martin Kolman <mkolman>
Status: CLOSED ERRATA QA Contact: Release Test Team <release-test-team-automation>
Severity: high Docs Contact:
Priority: unspecified    
Version: 7.1CC: anaconda-maint-list, atodorov, bugproxy, extras-qa, g.kaviyarasu, hannsj_uhl, jonathan, mbanas, mkolman, vanmeeuwen+fedora, vpodzime
Target Milestone: beta   
Target Release: 7.1   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: anaconda-19.31.110-1 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: 1155026 Environment:
Last Closed: 2015-03-05 14:03:56 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1155026    
Bug Blocks: 1028479    
Attachments:
Description Flags
/var/log/messages file post installation
none
anaconda-ks.cfg none

Description Martin Kolman 2014-10-23 09:03:13 UTC
+++ This bug was initially created as a clone of Bug #1155026 +++

Description of problem:
When an Anaconda/Initial Setup addon is missing in the environment and the kickstart file contains an %addon section with some header option specified (like: %addon com_example_foo --argument='example'), parsing such kickstart results in an error. That is a bug because a missing addon shouldn't trigger any tracebacks as its %addon kickstart section can be simply ignored.

--- Additional comment from Fedora Blocker Bugs Application on 2014-10-21 11:40:51 CEST ---

Proposed as a Freeze Exception for 21-beta by Fedora user vpodzime using the blocker tracking app because:

 This bug causes the Initial Setup to crash not allowing user creation and other things during the first boot.

--- Additional comment from Martin Kolman on 2014-10-22 13:36:16 CEST ---

I'll just ad that due to this bug Initial Setup will not only not be shown on first start after install but it will also never be disabled. This means it will try to start on every boot just to crash, potentially slowing down the boot a bit and maybe also introducing some interruptions to the Plymouth boot screen.

--- Additional comment from Adam Williamson (Red Hat) on 2014-10-22 19:56:23 CEST ---

Discussed at 2014-10-22 freeze exception review meeting: http://meetbot.fedoraproject.org/fedora-blocker-review/2014-10-22/f21-blocker-review.2014-10-22-16.03.log.txt . For now we're rejecting this, but we're open to a re-proposal.

It's somewhat unclear from the description whether a typical deployment of any Fedora media are going to hit this, or if it only hits custom use of initial-setup which none of our media do. If you can only hit it by using a custom kickstart that specifies %addon we're inclined to reject it, because we don't think that's a very common thing to do and not worth breaking freeze for at this point.

If you'd like us to re-consider this, please re-propose with more details as to why it's worth breaking freeze to fix this. thanks!

--- Additional comment from Vratislav Podzimek on 2014-10-23 10:54:39 CEST ---

(In reply to Adam Williamson (Red Hat) from comment #3)
> Discussed at 2014-10-22 freeze exception review meeting:
> http://meetbot.fedoraproject.org/fedora-blocker-review/2014-10-22/f21-
> blocker-review.2014-10-22-16.03.log.txt . For now we're rejecting this, but
> we're open to a re-proposal.
> 
> It's somewhat unclear from the description whether a typical deployment of
> any Fedora media are going to hit this, or if it only hits custom use of
> initial-setup which none of our media do. If you can only hit it by using a
> custom kickstart that specifies %addon we're inclined to reject it, because
> we don't think that's a very common thing to do and not worth breaking
> freeze for at this point.
> 
> If you'd like us to re-consider this, please re-propose with more details as
> to why it's worth breaking freeze to fix this. thanks!
Okay guys, let me express it more clearly:
Initial Setup doesn't run on default installation where it is supposed to run due to this bug. The kdump anaconda addon has been added to the installation images (and it's UI can be enabled by inst.kdump_addon=on) which results in an %addon section being written out to every installation's /root/anaconda-ks.cfg file which is then processed by the Initial Setup. Due to this bug IS crashes and leaves itself enabled so it runs and crashes on every boot. If no user account is created in the installation process, no user can be created before users get to KDM/XDM/?DM.

This doesn't affect GNOME because Initial Setup is not installed together with GNOME as that provides its own initial setup utility.

Re-proposing as I really think this is worth fixing as FE.

Comment 1 Martin Kolman 2014-10-23 09:04:16 UTC
This breaks RHEL7 Initial Setup in the same way as the F21 IS.

Comment 4 Adam Williamson 2014-10-25 14:18:57 UTC
please be careful to remove Fedora 'metadata' when cloning to RHEL, thanks :)

Comment 5 Martin Banas 2014-11-20 07:36:20 UTC
This should be fixed on beta.

Comment 6 David Shea 2014-11-21 13:51:33 UTC
*** Bug 1166564 has been marked as a duplicate of this bug. ***

Comment 7 IBM Bug Proxy 2014-11-21 14:00:35 UTC
Created attachment 959746 [details]
/var/log/messages file post installation

default comment by bridge

Comment 8 IBM Bug Proxy 2014-11-21 14:00:36 UTC
Created attachment 959747 [details]
anaconda-ks.cfg

default comment by bridge

Comment 10 Alexander Todorov 2014-11-26 14:34:59 UTC
anaconda-19.31.111-1

Tested with ks.cfg containing:

%addon org_fedora_hello_word --reverse
Text goes here
%end


the org_fedora_hello_world addon is not present. 

Results:
Installation proceeds in accordance with kickstart instructions. Moving to VERIFIED.

Comment 11 IBM Bug Proxy 2014-12-16 16:00:33 UTC
------- Comment From ssant.com 2014-12-16 15:55 EDT-------
Verified with beta build.

Comment 13 errata-xmlrpc 2015-03-05 14:03:56 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2015-0312.html