Bug 1157160

Summary:	Bad /etc/logrotate.d file installed by glusterfs
Product:	[Fedora] Fedora	Reporter:	Sam Varshavchik <mrsam>
Component:	glusterfs	Assignee:	Lalatendu Mohanty <lmohanty>
Status:	CLOSED DUPLICATE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	20	CC:	barumuga, humble.devassy, joe, jonathansteffan, kkeithle, lmohanty, ndevos, silas
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2014-10-27 13:44:47 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1126801, 1157457
Bug Blocks:

Description Sam Varshavchik 2014-10-25 14:47:23 UTC

Description of problem:

The glusterfs package installs an /etc/logrotate.d file that changes the global logrotate configuration that impacts all log files systemwide, not just glusterfs's.

Version-Release number of selected component (if applicable):

glusterfs-3.5.2-1.fc20

How reproducible:

Always

Steps to Reproduce:
1. Install Fedora without glusterfs or any other package that pulls in glusterfs, like libvirt/qemu, etc...
2. After a month, or so, observe that various log files are rotated out after four log rotation intervals
3. Install glusterfs, or any package that pulls in glusterfs

Actual results:

Suddenly, all system log files will now be rotated out after 52 log rotation intervals. /var/log won't be purged for at least a year, now.

Expected results:

Installing glusterfs should not affact any other packages' log rotation policies.

Additional info:

The "rotate 52" directive in /etc/logrotate.d/glusterfs-georep, and the other four directives in that file, take effect globally. They apply not only to the log files listed in this specific logrotate configuration file, but to all logrotate files.

Those four directives need to be manually moved inside each individually config file entry, in this file.

Comment 1 Niels de Vos 2014-10-27 09:59:28 UTC

Bug 1157457 has been filed to get the change in the upstream sources.

Comment 2 Niels de Vos 2014-10-27 10:18:56 UTC

In fact, bug 1126802 (master branch) was already filed for this in the upstream project. This bug in the Fedora package will get fixed when Bug 1126801 has been fixed in upstream.

Comment 3 Sam Varshavchik 2014-10-27 10:52:01 UTC

I see no reason to wait, especially since the fix is trivial.

Comment 4 Niels de Vos 2014-10-27 11:06:23 UTC

(In reply to Sam Varshavchik from comment #3)
> I see no reason to wait, especially since the fix is trivial.

We're planning to include a fix in the next 3.5 stable update. Currently the Fedora package does not include its own logrotate configuration and just installs the files from upstream. It surely is cleaner to fix this upstream first.

Comment 5 Sam Varshavchik 2014-10-27 12:41:35 UTC

Certainly it's cleaner to fix it upstream. But, instead of waiting for the upstream fix to percolate down, why not fix it in the package ahead of time, instead of waiting for the fixed version to get here.

There are a couple of other global logrotate config directives in glusterfs's config file. I haven't analyzed their full impact; but it's a fair chance that they might end up having more negative impact than just the extended rotation interval, for some package that expects its log files to inherit the logrotate defaults.

Comment 6 Kaleb KEITHLEY 2014-10-27 13:44:47 UTC


*** This bug has been marked as a duplicate of bug 1143916 ***