Bug 1157213 (brutalchess)
| Summary: | Review Request: brutalchess - Chess game with impressive 3D graphics | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Raphael Groner <projects.rg> |
| Component: | Package Review | Assignee: | Rex Dieter <rdieter> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | extras-qa, fedora-package-review, lupinix.fedora, micah.roth, package-review, projects.rg, rdieter, theo148, timur.kristof |
| Target Milestone: | --- | Flags: | rdieter:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | brutalchess-0.5.2-0.5.alpha.fc21 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | 701812 | Environment: | |
| Last Closed: | 2015-01-01 08:58:00 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
| Bug Depends On: | |||
| Bug Blocks: | 1174301 | ||
|
Description
Raphael Groner
2014-10-26 08:59:55 UTC
*** Bug 701812 has been marked as a duplicate of this bug. *** Updated broken BR without any release bump. rawhide build: http://koji.fedoraproject.org/koji/taskinfo?taskID=8351560 Release #2. Spec URL: https://raphgro.fedorapeople.org/review/brutalchess/brutalchess.spec SRPM URL: https://raphgro.fedorapeople.org/review/brutalchess/brutalchess-0.5.2-2.alpha.fc20.src.rpm rawhide build: http://koji.fedoraproject.org/koji/taskinfo?taskID=8352679 naming: NOT ok
1. MUST fix, pkg Summary doesn't match bugzilla Summary
Summary: Impressive 3D chess game
vs
Summary: Chess game with full 3D graphics
I'd suggest simpler:
Summary: Chess game with 3D graphics
(I don't think including "full" there adds value)
licensing: ok
sources: ok, verified content to be identical to upstream + run through pruning script.
macros: NOT ok
2. MUST fix commented macros
#%global buildtex 0
doesn't work as you expect, macros in comments are still evaluated (yes wierd, but that's how rpm works). Better:
#global buildtex 0
scriptlets: n/a
dir/file ownership: NOT ok,
3. package MUST own %{_datadir}/%{name} dir
you can either add
%dir %{_datadir}/%{name}/
or replace all of:
%{_datadir}/%{name}/art/
%{_datadir}/%{name}/models/
%{_datadir}/%{name}/fonts/
with just:
%{_datadir}/%{name}/
Please fix items 1-3, and things are looking good.
additional comments:
* I can help fix tex/font issues post-review, it's just a matter of missing BuildRequires
> additional comments:
> * I can help fix tex/font issues post-review, it's just a matter of missing
Yes, that would be so kind of you. I am totally lost within tex world, as it turns out.
The other things will be fixed soon, stay tuned for an upcoming new release.
Release #3. Spec URL: https://raphgro.fedorapeople.org/review/brutalchess/brutalchess.spec SRPM URL: https://raphgro.fedorapeople.org/review/brutalchess/brutalchess-0.5.2-3.alpha.fc20.src.rpm rawhide build: http://koji.fedoraproject.org/koji/taskinfo?taskID=8362131 Thanks for the review! Looks good, APPROVED New Package SCM Request ======================= Package Name: brutalchess Short Description: Chess game with impressive 3D graphics Upstream URL: http://sf.net/projects/brutalchess Owners: raphgro Branches: f21 InitialCC: rdieter lupinix Git done (by process-git-requests). brutalchess-0.5.2-3.alpha.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/brutalchess-0.5.2-3.alpha.fc21 Release tag doesn't match guidelines, alpha is a pre-release and requires 0.x instead of x: https://fedoraproject.org/wiki/Packaging:NamingGuidelines#Release_Tag (In reply to Fedora Update System from comment #10) > brutalchess-0.5.2-3.alpha.fc21 has been submitted as an update for Fedora 21. Deleted because of wrong Release tag. We are investigating to fix it and a valid package will follow soon. brutalchess-0.5.2-0.3.alpha.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/brutalchess-0.5.2-0.3.alpha.fc21 brutalchess-0.5.2-0.3.alpha.fc21 has been pushed to the Fedora 21 testing repository. brutalchess-0.5.2-0.5.alpha.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/brutalchess-0.5.2-0.5.alpha.fc21 brutalchess-0.5.2-0.5.alpha.fc21 has been pushed to the Fedora 21 stable repository. |