Bug 11578

Summary: ip-up/down passes parameters insecure to ip-up/down.local
Product: [Retired] Red Hat Linux Reporter: thk
Component: initscriptsAssignee: Bill Nottingham <notting>
Status: CLOSED RAWHIDE QA Contact:
Severity: medium Docs Contact:
Priority: medium    
Version: 6.2CC: rvokal
Target Milestone: ---   
Target Release: ---   
Hardware: i386   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2000-05-22 14:39:04 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description thk 2000-05-22 14:39:04 UTC
/etc/ppp/ip-up and /etc/ppp/ip-down should pass parameters to
ip-up.local and ip-down.local with "$@", *not* with $*

reproduce error:
If you start a pppd with 'pty' parameter the
ip-up/down scripts are called with an empty $2 (tty_name).
In ip-up/down.local all parameter positions after that are shifted
by one.

solution:
edit /etc/ppp/ip-{up,down} and change all occurences
of $* into "$@"  (with doublequotes)

Comment 1 Bill Nottingham 2000-07-12 19:10:22 UTC
Fixed in the latest initscripts packages.