Bug 1157846

Summary: New VLAN interface not saved if MAC address blank
Product: Red Hat OpenStack Reporter: Dan Sneddon <dsneddon>
Component: rubygem-staypuftAssignee: Mike Burns <mburns>
Status: CLOSED EOL QA Contact: Omri Hochman <ohochman>
Severity: unspecified Docs Contact:
Priority: unspecified    
Version: 5.0 (RHEL 7)CC: dsneddon, mburns, pasik, racedoro, srevivo
Target Milestone: ---Keywords: ZStream
Target Release: Installer   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-09-29 13:41:12 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Attachments:
Description Flags
Bonding Error (happened when I tried to save a bond with the MAC address of one of the members) none

Description Dan Sneddon 2014-10-27 20:48:01 UTC 
Description of problem:
When creating a new VLAN interface for a host, StayPuft does not save the interface when submitted if the MAC address field is blank.

Version-Release number of selected component (if applicable):
rubygem-staypuft: 0.4.10
rhel-osp-installer from 2014-10-23.2 repo

How reproducible:
Happens every time

Steps to Reproduce:
1. Discover host
2. Edit host, go to Network tab
3. Configure eno1.28 (in this case), leave MAC address blank
4. Hit Submit

Actual results:
The interface is not saved, no error is given, but the interface does not appear in the provisioning template, and does not appear if you edit the host again.

Expected results:
It should save the interface. MAC address is not required in the ifcfg-eno1.28 file, so it shouldn't be required to enter in the UI. At the very least, it should raise an error.

Additional info:
Comment 2 Dan Sneddon 2014-10-27 22:04:13 UTC 
Note this bug also seems to affect Bonding. I tried to create bond0 without a MAC and it wasn't saved. I then tried to create it with the MAC address of the first bond member, and got the attached error.
Comment 3 Dan Sneddon 2014-10-27 22:05:20 UTC 
Created attachment 951166 [details]
Bonding Error (happened when I tried to save a bond with the MAC address of one of the members)
Comment 4 Mike Burns 2014-10-28 12:40:27 UTC 
Dan,

Can you try going through the staypuft workflow for this?

Create the subnets with vlans in the normal wizard (fill in the vlan field)
Go to the Deployment Summary screen
Click on the Hosts tab then the Assigned tab
check the host(s) you want to configure
click configure networks
click the button on the far right of a nic and choose bond and the mode
drag the vlan subnet onto the bonded interface
Go back to the host details screen and review the nics


I followed this and see:

bond0 with attached devices:  ens10 ens11 and no mac address
bond0.28 with the correct subnet attached and no address b/c it was external dhcp
bond0.38 with the correct subnet attached and an ip address b/c it's using Foreman's internal db
Comment 5 Dan Sneddon 2014-11-17 20:51:18 UTC 
It does work if I use the Staypuft workflow.
Comment 6 Jaromir Coufal 2016-09-29 13:41:12 UTC 
Closing list of bugs for RHEL OSP Installer since its support cycle has already ended [0]. If there is some bug closed by mistake, feel free to re-open.

For new deployments, please, use RHOSP director (starting with version 7).

-- Jaromir Coufal
-- Sr. Product Manager
-- Red Hat OpenStack Platform

[0] https://access.redhat.com/support/policy/updates/openstack/platform