Bug 1157976

Summary:	AFR gives EROFS when fop fails on all subvolumes when client-quorum is enabled
Product:	[Community] GlusterFS	Reporter:	Pranith Kumar K <pkarampu>
Component:	replicate	Assignee:	Pranith Kumar K <pkarampu>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	urgent	Docs Contact:
Priority:	urgent
Version:	mainline	CC:	bugs, csuleski, cww, gluster-bugs, storage-qa-internal, vagarwal
Target Milestone:	---
Target Release:	---
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:	glusterfs-3.7.0	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	1156224
Clones:	1162122 (view as bug list)		Environment:
Last Closed:	2015-05-15 17:08:59 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1156224
Bug Blocks:	1162122, 1162150

Comment 1 Pranith Kumar K 2014-10-28 07:28:39 UTC

When quorum is enabled and the fop fails on all the subvolumes, op_errno is set to EROFS which overrides the actual errno returned from bricks.

Comment 2 Anand Avati 2014-10-28 07:29:30 UTC

REVIEW: http://review.gluster.org/8984 (cluster/afr: Preserve errno in case of failures on all subvols) posted (#1) for review on master by Pranith Kumar Karampuri (pkarampu)

Comment 3 Anand Avati 2014-11-06 05:37:04 UTC

COMMIT: http://review.gluster.org/8984 committed in master by Vijay Bellur (vbellur) 
------
commit 8528253ddbac4cbcb7ce4881c085d9bfc0a82703
Author: Pranith Kumar K <pkarampu>
Date:   Tue Oct 28 11:48:02 2014 +0530

    cluster/afr: Preserve errno in case of failures on all subvols
    
    Problem:
    When quorum is enabled and the fop fails on all the subvolumes,
    op_errno is set to EROFS which overrides the actual errno returned
    from bricks.
    
    Fix:
    Don't override the errno when fop fails on all subvols.
    
    Change-Id: I61e57bbf1a69407230ec172a983de18d1c624fd2
    BUG: 1157976
    Signed-off-by: Pranith Kumar K <pkarampu>
    Reviewed-on: http://review.gluster.org/8984
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Krutika Dhananjay <kdhananj>
    Reviewed-by: Harshavardhana <harsha>
    Tested-by: Harshavardhana <harsha>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 4 Anand Avati 2014-11-10 11:42:51 UTC

REVIEW: http://review.gluster.org/9088 (cluster/afr: Preserve errno in case of failures on all subvols) posted (#1) for review on release-3.5 by Pranith Kumar Karampuri (pkarampu)

Comment 5 Niels de Vos 2015-05-15 17:08:59 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user