Bug 1158330

Summary: [GSS] (6.3.z) Memory leak in JBoss WS CXF Client's HandlerChainSortInterceptor
Product: [JBoss] JBoss Enterprise Application Platform 6 Reporter: Tadayoshi Sato <tasato>
Component: Web ServicesAssignee: baranowb <bbaranow>
Status: CLOSED CURRENTRELEASE QA Contact: Rostislav Svoboda <rsvoboda>
Severity: high Docs Contact:
Priority: high    
Version: 6.3.0CC: asoldano, bbaranow, cdewolf, istudens, jawilson, jdatta, rsvoboda
Target Milestone: CR1   
Target Release: EAP 6.3.3   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: 1155490 Environment:
Last Closed: 2019-08-19 12:39:23 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On: 1155490    
Bug Blocks: 1151405, 1157479    
Attachments:
Description Flags
6.3.2-vs-6.3.3 none

Description Tadayoshi Sato 2014-10-29 06:02:48 UTC
+++ This bug was initially created as a clone of Bug #1155490 +++

Description of problem:
Platform BZ for https://issues.jboss.org/browse/JBWS-3847

HandlerChainSortInterceptor.handleMessage(Message) sorts and sets JAX-WS handlers every time it handles a SOAP message:

   public void handleMessage(Message message) throws Fault
   {
      if (binding != null) {
         @SuppressWarnings("rawtypes")
         List<Handler> list = binding.getHandlerChain();
         if (list != null && !list.isEmpty()) {
            Collections.sort(list, comparator);
            binding.setHandlerChain(list);
         }
      }
   }

However, inside the org.apache.cxf.jaxws.binding.AbstractBindingImpl and org.apache.cxf.jaxws.support.JaxWsEndpointImpl implementations the handler chain is not reset every time but piled up with interceptors, which leads to subtle but indefinite memory leak in JBoss WS CXF client.

Furthermore, org.apache.cxf.jaxws.support.JaxWsEndpointImpl holds the interceptors as a kind of java.util.concurrent.CopyOnWriteArrayList. So modifying the growing list of interceptors per each message should cause a growing performance drawback, which is also not a good implementation.

How reproducible:
100%

Steps to Reproduce:
1. Implement a JAX-WS client with one JAX-WS handler
2. Run the client invoking the service port method indefinitely


Actual results:
You'll see memory leak (= increase of memory usage).


Expected results:
Memory leak should not happen.

Comment 2 JBoss JIRA Server 2014-10-30 10:07:56 UTC
Alessio Soldano <asoldano> updated the status of jira JBWS-3847 to Resolved

Comment 4 Rostislav Svoboda 2015-01-20 09:13:49 UTC
Verified on EAP 6.3.3 CR1. Custom app created, execute 1 million iterations. Screenshot of jconsole attached

Comment 5 Rostislav Svoboda 2015-01-20 09:14:16 UTC
Created attachment 981781 [details]
6.3.2-vs-6.3.3

Comment 6 JBoss JIRA Server 2015-04-25 20:26:42 UTC
Alessio Soldano <asoldano> updated the status of jira JBWS-3847 to Closed