Bug 1158537

Summary: Removing a resource from a group also removes constraints mentioning that group
Product: Red Hat Enterprise Linux 7 Reporter: Tomas Jelinek <tojeline>
Component: pcsAssignee: Tomas Jelinek <tojeline>
Status: CLOSED ERRATA QA Contact: cluster-qe <cluster-qe>
Severity: medium Docs Contact:
Priority: high    
Version: 7.1CC: cfeist, cluster-maint, mlisik, rsteiger, tojeline
Target Milestone: rc   
Target Release: ---   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: pcs-0.9.140-1.el7 Doc Type: Bug Fix
Doc Text:
Cause: User removes a resource from a group. Consequence: Constraints mentioning the group are removed. Fix: Remove the constraints only when there are no resources left in the group and therefore the group is going to be removed. Result: Constraints mentioning the group are preserved.
Story Points: ---
Clone Of:
: 1247979 (view as bug list) Environment:
Last Closed: 2015-11-19 09:33:03 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1247979    
Attachments:
Description Flags
proposed fix none

Description Tomas Jelinek 2014-10-29 15:13:05 UTC
Description of problem:
Removing a resource from a group also removes constraints mentioning that group.


Version-Release number of selected component (if applicable):
pcs-0.9.135


How reproducible:
always


Steps to Reproduce:
[root@rh70-node1:~]# pcs resource create dummy1 Dummy --group=dummies
[root@rh70-node1:~]# pcs resource create dummy2 Dummy --group=dummies
[root@rh70-node1:~]# pcs resource
 Resource Group: dummies
     dummy1     (ocf::heartbeat:Dummy): Started 
     dummy2     (ocf::heartbeat:Dummy): Started 
[root@rh70-node1:~]# pcs constraint location dummies rh70-node1=100
[root@rh70-node1:~]# pcs constraint
Location Constraints:
  Resource: dummies
    Enabled on: rh70-node1 (score:100)
Ordering Constraints:
Colocation Constraints:
[root@rh70-node1:~]# pcs resource group remove dummies dummy2
Removing Constraint - location-dummies-rh70-node1-100
[root@rh70-node1:~]# pcs constraint
Location Constraints:
Ordering Constraints:
Colocation Constraints:


Actual results:
Constraint related to the group has been removed.


Expected results:
Constraint related to the group is preserved.


Additional info:
github issue: https://github.com/feist/pcs/issues/46

Comment 1 Tomas Jelinek 2015-02-20 13:17:30 UTC
Created attachment 993906 [details]
proposed fix

Comment 3 Tomas Jelinek 2015-06-04 14:24:29 UTC
Before Fix:
[root@rh71-node1 ~]# rpm -q pcs
pcs-0.9.137-13.el7_1.2.x86_64
[root@rh71-node1:~]# pcs resource create dummy1 Dummy --group=dummies
[root@rh71-node1:~]# pcs resource create dummy2 Dummy --group=dummies
[root@rh71-node1:~]# pcs resource
 Resource Group: dummies
     dummy1     (ocf::heartbeat:Dummy): Started 
     dummy2     (ocf::heartbeat:Dummy): Started 
[root@rh71-node1:~]# pcs constraint location dummies prefers rh71-node1=100
[root@rh71-node1:~]# pcs constraint
Location Constraints:
  Resource: dummies
    Enabled on: rh71-node1 (score:100)
Ordering Constraints:
Colocation Constraints:
[root@rh71-node1:~]# pcs resource group remove dummies dummy2
Removing Constraint - location-dummies-rh71-node1-100
[root@rh71-node1:~]# pcs constraint
Location Constraints:
Ordering Constraints:
Colocation Constraints:



After Fix:
[root@rh71-node1:~]# rpm -q pcs
pcs-0.9.140-1.el6.x86_64
[root@rh71-node1:~]# pcs resource create dummy1 Dummy --group=dummies
[root@rh71-node1:~]# pcs resource create dummy2 Dummy --group=dummies
[root@rh71-node1:~]# pcs resource
 Resource Group: dummies
     dummy1     (ocf::heartbeat:Dummy): Started rh71-node3 
     dummy2     (ocf::heartbeat:Dummy): Started rh71-node3 
[root@rh71-node1:~]# pcs constraint location dummies prefers rh71-node1=100
[root@rh71-node1:~]# pcs constraint
Location Constraints:
  Resource: dummies
    Enabled on: rh71-node1 (score:100)
Ordering Constraints:
Colocation Constraints:
[root@rh71-node1:~]# pcs resource group remove dummies dummy2
[root@rh71-node1:~]# pcs constraint
Location Constraints:
  Resource: dummies
    Enabled on: rh71-node1 (score:100)
Ordering Constraints:
Colocation Constraints:

Comment 8 errata-xmlrpc 2015-11-19 09:33:03 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHSA-2015-2290.html