Bug 1158791
Summary: | [USS]: deletion and creation of snapshots with same name causes problems | ||
---|---|---|---|
Product: | [Community] GlusterFS | Reporter: | Raghavendra Bhat <rabhat> |
Component: | snapshot | Assignee: | Raghavendra Bhat <rabhat> |
Status: | CLOSED CURRENTRELEASE | QA Contact: | |
Severity: | unspecified | Docs Contact: | |
Priority: | unspecified | ||
Version: | 3.6.0 | CC: | bugs, gluster-bugs |
Target Milestone: | --- | ||
Target Release: | --- | ||
Hardware: | Unspecified | ||
OS: | Unspecified | ||
Whiteboard: | |||
Fixed In Version: | glusterfs-3.6.1 | Doc Type: | Bug Fix |
Doc Text: | Story Points: | --- | |
Clone Of: | 1151004 | Environment: | |
Last Closed: | 2014-11-10 15:14:35 UTC | Type: | Bug |
Regression: | --- | Mount Type: | --- |
Documentation: | --- | CRM: | |
Verified Versions: | Category: | --- | |
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
Cloudforms Team: | --- | Target Upstream Version: | |
Embargoed: | |||
Bug Depends On: | 1151004 | ||
Bug Blocks: | 1157452, 1157985 |
Description
Raghavendra Bhat
2014-10-30 09:03:56 UTC
REVIEW: http://review.gluster.org/9007 (features/snapview-server: check if the reference to the snapshot world is correct before doing any fop) posted (#1) for review on release-3.6 by Raghavendra Bhat (raghavendra) REVIEW: http://review.gluster.org/9008 (features/snapview-server: verify the fs instance in revalidated lookups as well) posted (#1) for review on release-3.6 by Raghavendra Bhat (raghavendra) COMMIT: http://review.gluster.org/9007 committed in release-3.6 by Vijay Bellur (vbellur) ------ commit 2ebb417e7558a35990b7c2784d25fe38ea975d0e Author: Raghavendra Bhat <raghavendra> Date: Thu Oct 9 17:32:48 2014 +0530 features/snapview-server: check if the reference to the snapshot world is correct before doing any fop The following operations might lead to problems: * Create a file on the glusterfs mount point * Create a snapshot (say "snap1") * Access the contents of the snapshot * Delete the file from the mount point * Delete the snapshot "snap1" * Create a new snapshot "snap1" Now accessing the new snapshot "snap1" gives problems. Because the inode and dentry created for snap1 would not be deleted upon the deletion of the snapshot (as deletion of snapshot is a gluster cli operation, not a fop). So next time upon creation of a new snap with same name, the previous inode and dentry itself will be used. But the inode context contains old information about the glfs_t instance and the handle in the gfapi world. Directly accessing them without proper check leads to ENOTCONN errors. Thus the glfs_t instance should be checked before accessing. If its wrong, then right instance should be obtained by doing the lookup. Change-Id: I975245b8f6b7fea0a90eb5e36e8149d12457ac10 BUG: 1158791 Reviewed-on: http://review.gluster.org/9007 Reviewed-by: Vijay Bellur <vbellur> Tested-by: Vijay Bellur <vbellur> COMMIT: http://review.gluster.org/9008 committed in release-3.6 by Vijay Bellur (vbellur) ------ commit c2326236e9bac86abe1131d34b018c7d5a87813f Author: Raghavendra Bhat <raghavendra> Date: Wed Oct 29 17:47:48 2014 +0530 features/snapview-server: verify the fs instance in revalidated lookups as well Change-Id: I691635e60aba72642c3c79d7da472884f1228301 BUG: 1158791 Reviewed-on: http://review.gluster.org/9008 Tested-by: Gluster Build System <jenkins.com> Reviewed-by: Vijay Bellur <vbellur> This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.6.1, please reopen this bug report. glusterfs-3.6.1 has been announced [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution. [1] http://supercolony.gluster.org/pipermail/gluster-users/2014-November/019410.html [2] http://supercolony.gluster.org/mailman/listinfo/gluster-users *** Bug 1157985 has been marked as a duplicate of this bug. *** |