Bug 1158981

Summary:	"Unservable packages" warning is always displayed
Product:	Red Hat Satellite 5	Reporter:	Lukáš Hellebrandt <lhellebr>
Component:	WebUI	Assignee:	Jiri Precechtel <jprecech>
Status:	CLOSED ERRATA	QA Contact:	Red Hat Satellite QA List <satqe-list>
Severity:	high	Docs Contact:
Priority:	high
Version:	570	CC:	ahuchcha, jesse.johnson, jhutar, jprecech, ktordeur, tkasparek, tlestach, xdmoon
Target Milestone:	---
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	spacewalk-java-2.3.8-135-sat	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2016-06-02 12:32:57 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1101469
Bug Blocks:	465198, 1162131

Description Lukáš Hellebrandt 2014-10-30 15:52:26 UTC

Description of problem:
In provisioning->snapshots, after opening a snapshot the "The snapshot package list has unservable packages; do not attempt to rollback." warning is always displayed regardless of snapshot type. Whatever action it is that created the snapshot (entitlement adding, package installation...), this warning is displayed which doesn't make sense to me. The "unservable packages" part is clickable and upon opening it, the list of 0 packages is displayed. So this warning is basically telling me "I can not rollback to this snapshot where you didn't change any package because I can not serve you these 0 packages". After attempting to rollback, the rollback is succesful.


How reproducible:
Always

Steps to Reproduce:
1. Have a satellite 570 with a system with provisioning entitlement registered
2. Do any action (e.g., change entitlements, install a package...)
3. Go to provisioning->snapshots, select any snapshot
4. Notice the warning. Click the link in warning and notice there are no packages displayed

Actual results:
A warning is shown that doesn't make any sense in this context

Expected results:
It shouldn't be shown

Comment 4 Tomas Lestach 2016-02-25 13:05:26 UTC

As I understand the bug report, it's only about displaying a warning even for cases, when the warning isn't relevant.
That means this bug isn't a blocker. As such it as a low priority.

Comment 5 Jiri Precechtel 2016-03-30 14:09:23 UTC

Fixed, warning "Unservable packages" is not shown in case that unservable packages don't exist in the snapshot selected for rollback now.

Spacewalk-git-commit: 288027e1ef093d6bd6bab0accabefd851cbe8dba

If the solution does not work for you, re-assign this bug please.

Comment 6 Tomáš Kašpárek 2016-04-18 07:11:08 UTC

correct commit containing changes is this one: 1f1e502edf3dea0b63b9d123ecf6f1aa84731cd8

Comment 7 Tomas Lestach 2016-04-18 07:44:52 UTC

Wrong commit is stated in Comment 5.
The correct one is ...

spacewalk.git: 1f1e502edf3dea0b63b9d123ecf6f1aa84731cd8

Comment 11 Lukáš Hellebrandt 2016-04-26 11:28:55 UTC

Verified with spacewalk-schema-2.3.2-25 and spacewalk-java-2.3.8-135 on sat57 RHEL6 EmbPostgreSQL.

Followed the steps from comment 1. No warning was shown when rolling back entitlement changes. A warning was (correctly) shown when attempting to rollback uninstalling package that was not available on the Satellite to be installed back.

Comment 13 errata-xmlrpc 2016-06-02 12:32:57 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2016:1200