Bug 1159248

Summary: glupy compilation issue
Product: [Community] GlusterFS Reporter: Kiran Patil <kiran>
Component: buildAssignee: Niels de Vos <ndevos>
Status: CLOSED UPSTREAM QA Contact:
Severity: high Docs Contact:
Priority: unspecified    
Version: mainlineCC: bugs, gluster-bugs, ndevos
Target Milestone: ---   
Target Release: ---   
Hardware: x86_64   
OS: Linux   
Whiteboard:
Fixed In Version: Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-12-01 06:53:31 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Kiran Patil 2014-10-31 09:58:17 UTC
Description of problem:
glupy translator has compilation issue

Version-Release number of selected component (if applicable):
master branch

How reproducible:
Always

Steps to Reproduce:
1. goto gluster source (cd glusterfs)
2. ./configure
3. make
4. make install

Actual results:

Making all in glupy
Making all in src
  CC     glupy.lo
  CCLD   glupy.la
/usr/bin/ld: skipping incompatible /usr/lib/libdl.so when searching for -ldl
/usr/bin/ld: skipping incompatible /usr/lib/libutil.so when searching for -lutil
/usr/bin/ld: skipping incompatible /usr/lib/libm.so when searching for -lm
/usr/bin/ld: skipping incompatible /usr/lib/librt.so when searching for -lrt
/usr/bin/ld: skipping incompatible /usr/lib/libpthread.so when searching for -lpthread
/usr/bin/ld: skipping incompatible /usr/lib/libc.so when searching for -lc

and

glupy.py__init__.py
 /bin/sh ../../../../libtool --quiet  --mode=install /usr/bin/install -c   glupy.la '/usr/local/lib/glusterfs/3.6.0beta3/xlator/features'
libtool: install: warning: relinking `glupy.la'
/usr/bin/ld: skipping incompatible /usr/lib/libdl.so when searching for -ldl
/usr/bin/ld: skipping incompatible /usr/lib/libutil.so when searching for -lutil
/usr/bin/ld: skipping incompatible /usr/lib/libm.so when searching for -lm
/usr/bin/ld: skipping incompatible /usr/lib/librt.so when searching for -lrt
/usr/bin/ld: skipping incompatible /usr/lib/libpthread.so when searching for -lpthread
/usr/bin/ld: skipping incompatible /usr/lib/libc.so when searching for -lc


Expected results:
Successful compilation without any errors

Additional info:
A fix suggested by Niels.

diff --git a/configure.ac b/configure.ac
index 3757c33..3dd741c 100644
--- a/configure.ac
+++ b/configure.ac
@@ -1007,7 +1007,7 @@ case $host_os in
      linux*)
        CFLAGS="`${PYTHON}-config --cflags`"
        CPPFLAGS=$CFLAGS
-       LDFLAGS="-L`${PYTHON}-config --prefix`/lib `${PYTHON}-config --ldflags`"
+       LDFLAGS="-L`${PYTHON}-config --prefix`/$libdir `${PYTHON}-config --ldflags`"
        ;;
      darwin*)
        CFLAGS="`${PYTHON}-config --cflags`"

Comment 1 Anand Avati 2014-11-01 12:12:34 UTC
REVIEW: http://review.gluster.org/9033 (build: fix glupy linking warnings) posted (#1) for review on master by Niels de Vos (ndevos)

Comment 2 Anand Avati 2014-11-06 17:50:08 UTC
REVIEW: http://review.gluster.org/9033 (build: fix glupy linking warnings) posted (#2) for review on master by Niels de Vos (ndevos)

Comment 3 Anand Avati 2014-11-12 16:11:33 UTC
COMMIT: http://review.gluster.org/9033 committed in master by Niels de Vos (ndevos) 
------
commit b6c553339ca0d14dc8d66ccc5d8d8db2be1dd14f
Author: Niels de Vos <ndevos>
Date:   Sat Nov 1 13:05:08 2014 +0100

    build: fix glupy linking warnings
    
    While building glupy on x86_64, the following warnings are thrown:
    
      Making all in glupy
      Making all in src
        CC     glupy.lo
        CCLD   glupy.la
      /usr/bin/ld: skipping incompatible /usr/lib/libdl.so when searching for -ldl
      /usr/bin/ld: skipping incompatible /usr/lib/libutil.so when searching for -lutil
      /usr/bin/ld: skipping incompatible /usr/lib/libm.so when searching for -lm
      /usr/bin/ld: skipping incompatible /usr/lib/librt.so when searching for -lrt
      /usr/bin/ld: skipping incompatible /usr/lib/libpthread.so when searching for -lpthread
      /usr/bin/ld: skipping incompatible /usr/lib/libc.so when searching for -lc
    
    The libraries to link against are in /usr/lib64 on x86_64 in Fedora,
    RHEL and CentOS. Other architectures or distributions may use a
    different path. Instead of hardcoding "/lib" in configure.ac, the
    variable $libdir should be used so that the path gets adapted to the
    distribution and architecture.
    
    Change-Id: Iae5db3ee8a62959ccb7f958d7c95eb77c4d4b1dd
    BUG: 1159248
    Reported-by: Kiran Patil <kiran>
    Signed-off-by: Niels de Vos <ndevos>
    Reviewed-on: http://review.gluster.org/9033
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Kaleb KEITHLEY <kkeithle>
    Reviewed-by: Humble Devassy Chirammal <humble.devassy>

Comment 4 Kiran Patil 2014-12-01 06:53:31 UTC
Closing this bug since the fix at master branch resolved the issue.