Bug 1159601
| Summary: | Review Request: php-twig-extensions - Twig extensions | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Shawn Iwinski <shawn> | ||||||
| Component: | Package Review | Assignee: | Remi Collet <fedora> | ||||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||
| Severity: | medium | Docs Contact: | |||||||
| Priority: | medium | ||||||||
| Version: | rawhide | CC: | fedora, package-review | ||||||
| Target Milestone: | --- | Flags: | fedora:
fedora-review+
gwync: fedora-cvs+ |
||||||
| Target Release: | --- | ||||||||
| Hardware: | All | ||||||||
| OS: | Linux | ||||||||
| Whiteboard: | |||||||||
| Fixed In Version: | php-twig-extensions-1.2.0-2.el7 | Doc Type: | Bug Fix | ||||||
| Doc Text: | Story Points: | --- | |||||||
| Clone Of: | Environment: | ||||||||
| Last Closed: | 2014-11-18 12:19:08 UTC | Type: | --- | ||||||
| Regression: | --- | Mount Type: | --- | ||||||
| Documentation: | --- | CRM: | |||||||
| Verified Versions: | Category: | --- | |||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||
| Embargoed: | |||||||||
| Attachments: |
|
||||||||
|
Description
Shawn Iwinski
2014-11-02 06:23:38 UTC
Created attachment 953502 [details]
phpci.log
phpCompatInfo version 3.5.0 static analyze runs in src directory
Created attachment 953503 [details]
review.txt
Generated by fedora-review 0.5.2 (63c24cb) last change: 2014-07-14
MUST:
[!]: Package does not own files or directories owned by other packages.
Note: Dirs in package are owned also by: /usr/share/php/Twig(php-twig)
=> drop ownership, as php-twig is required by this package
SHOULD
[!]: Dist tag is present (not strictly required in GL).
=> use %{?dist}
Not a blocker, just for information (could raise failure in f<=20, epel<=6 where old phpunit version still requires xdebug)
[?]: Package functions as described.
[?]: %check is present and all tests pass.
=> Test suite OK, but can raise error with some extension
(Seems XDebug related)
- Conditional %{?dist}
- Removed color turn off and default timezone for phpunit
- Removed "%dir %{phpdir}/Twig" from %files
Diff: https://github.com/siwinski/rpms/commit/11d108471b3521610785acacbd1324eec1b3cc20
Spec URL: https://raw.githubusercontent.com/siwinski/rpms/11d108471b3521610785acacbd1324eec1b3cc20/php-twig-extensions.spec
SRPM URL: https://siwinski.fedorapeople.org/copr/php-experimental/php-twig-extensions-1.2.0-2.fc20.src.rpm
[x]: Package does not own files or directories owned by other packages. [x]: Dist tag is present (not strictly required in GL). No blocker === APPROVED === THANKS for the review! New Package SCM Request ======================= Package Name: php-twig-extensions Short Description: Twig extensions Upstream URL: https://github.com/twigphp/Twig-extensions Owners: siwinski Branches: f21 epel7 InitialCC: Git done (by process-git-requests). php-twig-extensions-1.2.0-2.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/php-twig-extensions-1.2.0-2.fc21 php-twig-extensions-1.2.0-2.el7 has been submitted as an update for Fedora EPEL 7. https://admin.fedoraproject.org/updates/php-twig-extensions-1.2.0-2.el7 php-twig-extensions-1.2.0-2.el7 has been pushed to the Fedora EPEL 7 testing repository. php-twig-extensions-1.2.0-2.fc21 has been pushed to the Fedora 21 stable repository. php-twig-extensions-1.2.0-2.el7 has been pushed to the Fedora EPEL 7 stable repository. Package Change Request ====================== Package Name: php-twig-extensions New Branches: el6 Owners: siwinski InitialCC: Git done (by process-git-requests). |