Bug 115979
Summary: | xferlog doesn't honor TZ environment variable | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | Red Hat Enterprise Linux 2.1 | Reporter: | Neil Horman <nhorman> | ||||||
Component: | wu-ftpd | Assignee: | Thomas Woerner <twoerner> | ||||||
Status: | CLOSED ERRATA | QA Contact: | |||||||
Severity: | medium | Docs Contact: | |||||||
Priority: | medium | ||||||||
Version: | 2.1 | CC: | tao | ||||||
Target Milestone: | --- | ||||||||
Target Release: | --- | ||||||||
Hardware: | All | ||||||||
OS: | Linux | ||||||||
Whiteboard: | |||||||||
Fixed In Version: | Doc Type: | Bug Fix | |||||||
Doc Text: | Story Points: | --- | |||||||
Clone Of: | Environment: | ||||||||
Last Closed: | 2004-03-15 11:12:03 UTC | Type: | --- | ||||||
Regression: | --- | Mount Type: | --- | ||||||
Documentation: | --- | CRM: | |||||||
Verified Versions: | Category: | --- | |||||||
oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||
Cloudforms Team: | --- | Target Upstream Version: | |||||||
Embargoed: | |||||||||
Attachments: |
|
Description
Neil Horman
2004-02-17 13:25:31 UTC
Created attachment 97746 [details]
patch to cause xferlog to record timestamps which honor local time zone
the time calls which were used to get the time that gets written into xferlog
have been replaced with calls to mktime(localtime(NULL));
Will be fixed in the next erratum. The patch that was released does not work. Causes segmentation faults in ftpd. localtime(NULL) returns NULL. mktime(NULL) will segfault. A patch that actually works will be attached. Thank you, Samuel Stringham Rackspace Fanatical Support Created attachment 98430 [details]
fix for mktime() segfault
your right. I'm sorry, I don't know how I got that in there. I should have called time(NULL first) and passed the address of the return value to localtime as you did. apologies Please have a look at: http://people.redhat.com/twoerner/SRPMS/2.1AS/wu-ftpd-2.6.1-23.1.src.rpm http://people.redhat.com/twoerner/RPMS/2.1AS/wu-ftpd-2.6.1-23.1.i386.rpm Will soon be released as erratum. Hi Thomas, it looks like you've left the "%patch9" line out of the spec file - as far as I can tell the updated wu-ftpd-2.6.2-time_fix.patch doesn't get applied prior to build. Ok, here is the final version: http://people.redhat.com/twoerner/SRPMS/2.1AS/wu-ftpd-2.6.1-23.2.src.rpm http://people.redhat.com/twoerner/RPMS/2.1AS/wu-ftpd-2.6.1-23.2.i386.rpm RHBA-2004:135 is now pushed live |