Bug 1161109
| Summary: | Review Request:nodejs-events - Nodes event emitter | ||
|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | anish <apatil> |
| Component: | Package Review | Assignee: | Parag AN(पराग) <panemade> |
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> |
| Severity: | medium | Docs Contact: | |
| Priority: | medium | ||
| Version: | rawhide | CC: | package-review, panemade, petersen |
| Target Milestone: | --- | Flags: | panemade:
fedora-review+
gwync: fedora-cvs+ |
| Target Release: | --- | ||
| Hardware: | All | ||
| OS: | Linux | ||
| Whiteboard: | |||
| Fixed In Version: | nodejs-events-1.0.2-1.fc20 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2014-12-25 05:29:38 UTC | Type: | --- |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
anish
2014-11-06 11:55:17 UTC
Review: + Package built successful in mock (f22 x86_64) + rpmlint on generated rpms gave output nodejs-events.noarch: W: spelling-error %description -l en_US js -> dis, ks, j nodejs-events.noarch: W: only-non-binary-in-usr-lib nodejs-events.src: W: spelling-error %description -l en_US js -> dis, ks, j 2 packages and 0 specfiles checked; 0 errors, 3 warnings. + Source verified with upstream as (sha256sum) srpm tarball: a8d3c4ea659a341628e3cc1c6ab73bce01363add8639dca612343c25632c3e5a upstream tarball: a8d3c4ea659a341628e3cc1c6ab73bce01363add8639dca612343c25632c3e5a + License is "MIT" and included in its own LICENSE file. + follows nodejs packaging guidelines. Suggestions: 1) I think you should write tests in %check and not based on conditional execute %check. So, remove unnecessary %check on line 35. 2) Use in Node's in summary and description instead of nodes APPROVED. thanks Parag for review New Package SCM Request ======================= Package Name: nodejs-events Short Description: Nodes event emitter Owners: anishpatil Branches: f20 f21 InitialCC: anishpatil Git done (by process-git-requests). nodejs-events-1.0.2-1.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/nodejs-events-1.0.2-1.fc21 nodejs-events-1.0.2-1.fc20 has been submitted as an update for Fedora 20. https://admin.fedoraproject.org/updates/nodejs-events-1.0.2-1.fc20 nodejs-events-1.0.2-1.fc21 has been pushed to the Fedora 21 testing repository. nodejs-events-1.0.2-1.fc20 has been pushed to the Fedora 20 stable repository. |