Bug 1161293

Summary: Review Request: fedora-productimg-server - Installer branding and configuration for Fedora Server
Product: [Fedora] Fedora Reporter: Matthew Miller <mattdm>
Component: Package ReviewAssignee: Stephen Gallagher <sgallagh>
Status: CLOSED ERRATA QA Contact: Fedora Extras Quality Assurance <extras-qa>
Severity: medium Docs Contact:
Priority: medium    
Version: rawhideCC: package-review, sgallagh
Target Milestone: ---Flags: sgallagh: fedora-review+
gwync: fedora-cvs+
Target Release: ---   
Hardware: All   
OS: Linux   
Whiteboard:
Fixed In Version: fedora-productimg-workstation-21-2.fc21 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2014-11-10 06:07:28 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Matthew Miller 2014-11-06 20:35:00 UTC
Spec URL: http://mattdm.org/misc/fedora/fedora-productimg-server.spec
SRPM URL: http://mattdm.org/misc/fedora/fedora-productimg-server-21-0.fc21.mattdm.src.rpm

Description: 

This package contains differentiated branding and configuration for Fedora
Server for use in a product.img file for Anaconda, the Fedora installer. It
is not useful on an installed system.


Fedora Account System Username: mattdm

Comment 2 Stephen Gallagher 2014-11-06 21:08:19 UTC
For the record, the license change was made at my request offline as part of this review.

This package is very simplistic (it only adds a few specialized symlinks), so the only real Packaging Guidelines it needs to match are:

 * License: OK
 * Naming Guidelines: OK
 * Spec in English: OK
 * No file conflicts: FAIL

So, one more go-around, I think.

Comment 3 Matthew Miller 2014-11-06 21:15:36 UTC
Conflict with other productimg packages:



Spec URL: http://mattdm.org/misc/fedora/fedora-productimg-server.spec
SRPM URL: http://mattdm.org/misc/fedora/fedora-productimg-server-21-2.fc21.mattdm.src.rpm

Comment 4 Matthew Miller 2014-11-06 21:17:16 UTC
I think we might want to ask for a blanket exception to the file conflicts rule here, as increasing numbers of productimg packages would be a combinatorial explosion of complexity, whereas without one could simply add a fedora-productimg-spin-kde (for example), with no fuss.

But for now, done by the book.

Comment 5 Stephen Gallagher 2014-11-06 21:25:15 UTC
(In reply to Matthew Miller from comment #4)
> I think we might want to ask for a blanket exception to the file conflicts
> rule here, as increasing numbers of productimg packages would be a
> combinatorial explosion of complexity, whereas without one could simply add
> a fedora-productimg-spin-kde (for example), with no fuss.
> 
> But for now, done by the book.

I agree, let's file an FPC ticket later.

In the meantime, approved.

Comment 6 Matthew Miller 2014-11-06 21:27:39 UTC
New Package SCM Request
=======================
Package Name: fedora-productimg-server
Short Description: Installer branding and configuration for Fedora Server
Upstream URL: n/a
Owners: mattdm sgallagh
Branches: f21
InitialCC:

Comment 7 Gwyn Ciesla 2014-11-07 13:03:35 UTC
Upstream URL is invalid.

Comment 8 Matthew Miller 2014-11-07 14:31:45 UTC
New Package SCM Request
=======================
Package Name: fedora-productimg-server
Short Description: Installer branding and configuration for Fedora Server
Upstream URL: http://fedoraproject.org/wiki/Server
Owners: mattdm sgallagh
Branches: f21
InitialCC:

Comment 9 Gwyn Ciesla 2014-11-07 15:54:57 UTC
Git done (by process-git-requests).

Comment 10 Fedora Update System 2014-11-07 16:32:19 UTC
fedora-productimg-workstation-21-2.fc21,fedora-productimg-server-21-2.fc21,fedora-productimg-cloud-21-2.fc21 has been submitted as an update for Fedora 21.
https://admin.fedoraproject.org/updates/fedora-productimg-workstation-21-2.fc21,fedora-productimg-server-21-2.fc21,fedora-productimg-cloud-21-2.fc21

Comment 11 Fedora Update System 2014-11-10 06:07:28 UTC
fedora-productimg-workstation-21-2.fc21, fedora-productimg-server-21-2.fc21, fedora-productimg-cloud-21-2.fc21 has been pushed to the Fedora 21 stable repository.  If problems still persist, please make note of it in this bug report.