Bug 1161541

Summary:	virNodeSetMemoryParameters API doesn't report any errors
Product:	Red Hat Enterprise Linux 7	Reporter:	Jincheng Miao <jmiao>
Component:	libvirt	Assignee:	Pavel Hrdina <phrdina>
Status:	CLOSED ERRATA	QA Contact:	Virtualization Bugs <virt-bugs>
Severity:	medium	Docs Contact:
Priority:	medium
Version:	7.1	CC:	dyuan, honzhang, lhuang, mzhan, phrdina, rbalakri
Target Milestone:	rc
Target Release:	---
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:	libvirt-1.2.16-1.el7	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-11-19 05:55:24 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Jincheng Miao 2014-11-07 10:26:16 UTC

Description of problem:
if an error occurs in virNodeSetMemoryParameters, it doesn't report any errors.
That is not our expect.

version:
libvirt-1.2.8-5.el7.x86_64

How reproducible:
100%

Step to reproduce:
1. set an invalid value '2' to merge-across-nodes
# virsh node-memory-tune --shm-merge-across-nodes 2

# echo $?
0

2. check in logfile
2014-11-05 04:51:56.206+0000: 3114: error : nodeSetMemoryParameterValue:1307 : failed to set shm_merge_across_nodes: Operation not permitted

Expect result:
The error should be reported to user from virNodeSetMemoryParameters.

Comment 1 Pavel Hrdina 2014-11-10 14:24:56 UTC

Upstream commit:

commit a5c7ea4536e59f98683149f4db5b0c0ae938c9ad
Author: Jincheng Miao <jmiao>
Date:   Fri Nov 7 11:27:00 2014 +0100

    nodeinfo: report error when failure in nodeSetMemoryParameters
    
    nodeSetMemoryParameters() will call nodeSetMemoryParameterValue()
    to set parameters. But it just filter the return code '-2' as
    failure. Indeed we should report error when rc is negative.
    
    https://bugzilla.redhat.com/show_bug.cgi?id=1161541
    
    Signed-off-by: Jincheng Miao <jmiao>

Comment 2 Pavel Hrdina 2015-05-05 12:19:04 UTC

v1.2.10-63-ga5c7ea4

Comment 5 Luyao Huang 2015-07-21 09:53:10 UTC

Verify this bug with libvirt-1.2.17-2.el7.x86_64:

# virsh node-memory-tune --shm-merge-across-nodes 2
error: Unable to change memory parameters
error: failed to set shm_merge_across_nodes: Operation not permitted

# echo $?
1

Comment 7 errata-xmlrpc 2015-11-19 05:55:24 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2015-2202.html