Bug 1161573

Summary:	Enhancement in tcp mount routine, replace usage of glfs_* functions
Product:	[Community] GlusterFS	Reporter:	Jiffin <jthottan>
Component:	nfs	Assignee:	bugs <bugs>
Status:	CLOSED WONTFIX	QA Contact:
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	mainline	CC:	bugs, kkeithle, ndevos, sankarshan, skoduri, vbellur
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	Unspecified
OS:	All
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2018-11-19 08:06:13 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1157223
Bug Blocks:

Description Jiffin 2014-11-07 11:11:51 UTC

Description of problem:

In gluster nfs , mount routine for tcp and udp are different.So it is better to keep them in similar format for easier understanding of the code.The main block for this implementation is that in udp mount uses glfs functions.
The enhancement makes code much more cleaner.

Comment 1 Niels de Vos 2014-11-07 13:46:27 UTC

Pointer:
- https://github.com/gluster/glusterfs/blob/7e49787/xlators/nfs/server/src/mount3.c#L2049

instead of glfs_*() functions, we should use syncop_*(). This requires moving code from libgfapi into the syncop framework.

The change for Bug 1157223 uses glfs_*() functions too.

http://review.gluster.org/9036 lists several other functions that should likely be adjusted in a similar way.

Comment 2 Vijay Bellur 2018-11-19 08:06:13 UTC

There is no active development happening on gnfs. Hence closing this bug.