Bug 1161664

Summary:	Upload manifest button remains clickable during upload.
Product:	Red Hat Satellite	Reporter:	jcallaha
Component:	Subscription Management	Assignee:	Walden Raines <walden>
Status:	CLOSED NEXTRELEASE	QA Contact:	jcallaha
Severity:	medium	Docs Contact:
Priority:	unspecified
Version:	Nightly	CC:	bkearney, rplevka, tomckay
Target Milestone:	Unspecified	Keywords:	Reopened, Triaged
Target Release:	Unused
Hardware:	Unspecified
OS:	Unspecified
URL:	http://projects.theforeman.org/issues/15396
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2017-08-01 20:01:42 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description jcallaha 2014-11-07 15:10:04 UTC

Description of problem: 
While uploading a manifest, the upload button's text changes to "Uploading.." with a spinner. However, the user is still able to click the button and trigger another upload.

How reproducible:
always

Steps to Reproduce:
1. Navigate to manifests page
2. Upload a new manifest
3. While the manifest is uploading, click the upload button again (while it says it is uploading)

Actual results:
The button triggers another upload, but that upload is caught with the error below.

Error during upload: Required lock is already taken by other running tasks. Please inspect their state, fix their errors and resume them. Required lock: read Conflicts with tasks:


Expected results:
The button should either be disabled, or clicking the button (during upload) shouldn't trigger another upload.

Comment 1 RHEL Program Management 2014-11-07 15:13:00 UTC

Since this issue was entered in Red Hat Bugzilla, the release flag has been
set to ? to ensure that it is properly evaluated for this release.

Comment 3 Roman Plevka 2015-05-22 14:07:02 UTC

Also,
when user leaves the page during the upload and comes back to it, the Button style resets so there is no sign nor reference to the upload which is going on in the background.
This might trick user to trigger another upload.

I think the system should check for any running tasks for the selected organization every time the page loads and decorate the button accordingly.

Comment 4 Bryan Kearney 2016-07-08 20:29:48 UTC

Per 6.3 planning, moving out non acked bugs to the backlog

Comment 6 Bryan Kearney 2017-03-13 20:11:45 UTC

I do not see this bug being addressed in the near term. If you believe closing this is an issue, please feel free to re-open with additional information.

Comment 7 Walden Raines 2017-03-14 14:05:05 UTC

This has actually been fixed already.  The you can still select another file but you cannot click the upload button when a manifest is being uploaded.

See http://projects.theforeman.org/issues/15396

Comment 8 Walden Raines 2017-03-14 14:05:32 UTC

Connecting redmine issue http://projects.theforeman.org/issues/15396 from this bug

Comment 10 Bryan Kearney 2017-08-01 20:01:42 UTC

The fix to this bug will be delivered with release 6.3 of Satellite.