Bug 1161717

Summary: Fix coverity warnings for 'tkstool'
Product: Red Hat Enterprise Linux 7 Reporter: Matthew Harmsen <mharmsen>
Component: pki-coreAssignee: Jack Magne <jmagne>
Status: CLOSED ERRATA QA Contact: Asha Akkiangady <aakkiang>
Severity: medium Docs Contact:
Priority: medium    
Version: 7.2CC: arubin, jmagne, rpattath
Target Milestone: rc   
Target Release: 7.3   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: pki-core-10.3.3-1.el7 Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of: Environment:
Last Closed: 2016-11-04 05:18:38 UTC Type: ---
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:

Description Matthew Harmsen 2014-11-07 17:13:47 UTC 
This bug is created as a clone of upstream ticket:
https://fedorahosted.org/pki/ticket/1199

Coverity testing of a recent version of the product produced the following warnings:

    * pki-core-10.1.2/base/native-tools/src/tkstool/secutil.c:3046:14: warning: Potential leak of memory pointed to by 'optstring' 
    * pki-core-10.1.2/base/native-tools/src/tkstool/secutil.c:2474:9: warning: Access to field 'contentTypeTag' results in a dereference of a null pointer (loaded from variable 'src')
    * pki-core-10.1.2/base/native-tools/src/tkstool/secutil.c:1422:9: warning: Dereference of null pointer 
    * pki-core-10.1.2/base/native-tools/src/tkstool/secutil.c:676:6: warning: Assigned value is garbage or undefined

Proposed milestone: Dogtag 10.2.3
Comment 2 Matthew Harmsen 2015-07-08 23:41:58 UTC 
The upstream ticket for this issue, PKI TRAC Ticket #1199 has been slated for Dogtag 10.3 (RHCS 9.1); propose moving to RHEL 7.3.
Comment 3 Matthew Harmsen 2015-07-10 15:50:00 UTC 
(In reply to Matthew Harmsen from comment #2)
> The upstream ticket for this issue, PKI TRAC Ticket #1199 has been slated
> for Dogtag 10.3 (RHCS 9.1); propose moving to RHEL 7.3.

Moving to RHEL 7.3
Comment 5 Matthew Harmsen 2016-01-07 00:44:18 UTC 
Per discussions in the RHEL 7.3 Triage meeting of 01/06/2016: priority medium
Comment 6 Matthew Harmsen 2016-06-22 00:58:08 UTC 
Changed 4 days ago by jmagne:

commit ff1b164d033870ad7c708d13f671587f93c50749 Author: Jack Magne <​jmagne.redhat.com> Date: Mon Jun 6 16:36:16 2016 -0700

    Fix coverity warnings for 'tkstool'

    Issues listed in the ticket addressed by this patch.

    Ticket #1199 : Fix coverity warnings for 'tkstool'.

Closing
Comment 8 Roshni 2016-09-02 20:04:25 UTC 
Jack,

Could you provide with the steps to verify this bug?
Comment 10 Roshni 2016-09-07 13:51:24 UTC 
Under Covscan tab of pki-core errata, checked all the sections under NEED_INSPECTION for pki-core-10.3.3-7.el7 and did not see the issue mentioned in this bug.
Comment 12 errata-xmlrpc 2016-11-04 05:18:38 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://rhn.redhat.com/errata/RHBA-2016-2396.html