Bug 1161775
| Summary: | No Fedora branding for Cockpit in Fedora 21 Server | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | [Fedora] Fedora | Reporter: | Andreas Nilsson <bugs> | ||||||||||||
| Component: | cockpit | Assignee: | Patrick Uiterwijk <puiterwijk> | ||||||||||||
| Status: | CLOSED ERRATA | QA Contact: | Fedora Extras Quality Assurance <extras-qa> | ||||||||||||
| Severity: | unspecified | Docs Contact: | |||||||||||||
| Priority: | unspecified | ||||||||||||||
| Version: | 21 | CC: | mruckman, puiterwijk, rlerch, sgallagh, stefw | ||||||||||||
| Target Milestone: | --- | ||||||||||||||
| Target Release: | --- | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | Unspecified | ||||||||||||||
| Whiteboard: | AcceptedFreezeException | ||||||||||||||
| Fixed In Version: | cockpit-0.27-3.fc21 | Doc Type: | Bug Fix | ||||||||||||
| Doc Text: | Story Points: | --- | |||||||||||||
| Clone Of: | Environment: | ||||||||||||||
| Last Closed: | 2014-11-25 03:06:42 UTC | Type: | Bug | ||||||||||||
| Regression: | --- | Mount Type: | --- | ||||||||||||
| Documentation: | --- | CRM: | |||||||||||||
| Verified Versions: | Category: | --- | |||||||||||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||||||||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||||||||||
| Embargoed: | |||||||||||||||
| Bug Depends On: | |||||||||||||||
| Bug Blocks: | 1043131 | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
Andreas Nilsson
2014-11-07 20:50:52 UTC
Fixed this in a branch here: https://github.com/andreasn/cockpit/tree/fedora-21-branding Proposed as a Freeze Exception for 21-final by Fedora user sgallagh using the blocker tracking app because: Cockpit is very much the public face of Fedora Server. Failing to include Fedora Server branding here would be unfortunate. Additionally, we want to remove erroneous statements about unsuitability for use (which is no longer true). Created attachment 959067 [details]
screenshot of login screen branding
Created attachment 959068 [details]
screenshot of top bar branding
So is this ready for me to put into a build? I think so, yes. It would need some feedback from Ryan Lerch. I'll try and hunt him down on IRC. Created attachment 959089 [details]
screenshot of login screen branding v2
Created attachment 959090 [details]
screenshot of top bar branding v2
Fixed the branch to address the feedback from Ryan and Stephen. Discussed in 2014-11-19 blocker review meeting. Branding shouldn't bring any problems. Please pull in the fix when it's ready. Andreas, unfortunately your branch is based on Cockpit master. However the changes need to be made to cockpit 0.27, which is what is in Fedora 21. In order to do this you should create your branch from the 0.27 tag: $ git branch new-fedora-21-branding 0.27 $ git checkout new-fedora-21-branding ... make the changes ... This one should be based on 0.27. Lets see if that works better: https://github.com/andreasn/cockpit/tree/new-fedora-21-branding I rebuilt Cockpit with the suggested Fedora server branding. It just says 'SERVER' by itself in a couple places. Is that intentional? Yes, that is what Ryan suggested on IRC. I had it say "FEDORA SERVER" at some point, but it was not good with the mixed fonts. This patch will need a UI review from Ryan, to make sure I got it all right in the end. Well it's being built as a Fedora 21 update now. So if there is additional things to change I can do a follow up build. And I really do think the 'SERVER' text should change, especially once logged in, since there's no mention of 'Fedora' anywhere. I'll prepare the graphics and ask Ryan about it once he comes around later today. cockpit-0.27-2.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/cockpit-0.27-2.fc21 Package cockpit-0.27-2.fc21: * should fix your issue, * was pushed to the Fedora 21 testing repository, * should be available at your local mirror within two days. Update it with: # su -c 'yum update --enablerepo=updates-testing cockpit-0.27-2.fc21' as soon as you are able to. Please go to the following url: https://admin.fedoraproject.org/updates/FEDORA-2014-15612/cockpit-0.27-2.fc21 then log in and leave karma (feedback). (In reply to Stef Walter from comment #15) > Well it's being built as a Fedora 21 update now. > > So if there is additional things to change I can do a follow up build. And I > really do think the 'SERVER' text should change, especially once logged in, > since there's no mention of 'Fedora' anywhere. I have it saying "Fedora Server" now https://github.com/andreasn/cockpit/tree/new-fedora-21-branding Created attachment 960917 [details]
screenshot of top bar branding v3
Updated top bar screenshot
Adding Ryan to cc for feedback on the branding. cockpit-0.27-2.fc21 has been pushed to the Fedora 21 stable repository. If problems still persist, please make note of it in this bug report. cockpit-0.27-3.fc21 has been submitted as an update for Fedora 21. https://admin.fedoraproject.org/updates/cockpit-0.27-3.fc21 cockpit-0.27-3.fc21 has been pushed to the Fedora 21 stable repository. If problems still persist, please make note of it in this bug report. The design work here was removed from Cockpit. It was challenged based on trademark grounds. See bug #1223866. |