Bug 1162097
| Summary: | crash after attempted spice channel hotplug | ||
|---|---|---|---|
| Product: | Red Hat Enterprise Linux 7 | Reporter: | CongDong <codong> |
| Component: | libvirt | Assignee: | Ján Tomko <jtomko> |
| Status: | CLOSED ERRATA | QA Contact: | Virtualization Bugs <virt-bugs> |
| Severity: | unspecified | Docs Contact: | |
| Priority: | unspecified | ||
| Version: | 7.1 | CC: | dyuan, jiahu, jtomko, juzhou, lcheng, mzhan, rbalakri, tzheng |
| Target Milestone: | rc | ||
| Target Release: | --- | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
| Whiteboard: | |||
| Fixed In Version: | libvirt-1.2.8-7.el7 | Doc Type: | Bug Fix |
| Doc Text: | Story Points: | --- | |
| Clone Of: | Environment: | ||
| Last Closed: | 2015-03-05 07:47:17 UTC | Type: | Bug |
| Regression: | --- | Mount Type: | --- |
| Documentation: | --- | CRM: | |
| Verified Versions: | Category: | --- | |
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |
| Cloudforms Team: | --- | Target Upstream Version: | |
| Embargoed: | |||
|
Description
CongDong
2014-11-10 09:25:42 UTC
Fixed upstream by:
commit b987684ff63a20ab1301c48ca4842930be044f6d
Author: Ján Tomko <jtomko>
CommitDate: 2014-11-11 14:12:15 +0100
Fix virDomainChrEquals for spicevmc
virDomainChrSourceDefIsEqual should return 'true' for
identical SPICEVMC chardevs, and those that have no source
specification.
After this change, a failed hotplug no longer leaves a stale
pointer in the domain definition.
https://bugzilla.redhat.com/show_bug.cgi?id=1162097
git describe: v1.2.10-76-gb987684
Reproduced this bug with libvirt-1.2.8-6.el7.x86_64.
# virsh start r7
Domain r7 started
# virsh dumpxml r7
...
<channel type='spicevmc'>
<target type='virtio' name='com.redhat.spice.0' state='disconnected'/>
<alias name='channel0'/>
<address type='virtio-serial' controller='0' bus='0' port='1'/>
</channel>
...
# cat spicevmc.xml
<channel type='spicevmc'>
<target type='virtio' name='com.redhat.spice.0'/>
<address type='virtio-serial' controller='0' bus='0' port='1'/>
</channel>
# virsh attach-device r7 spicevmc.xml
error: Failed to attach device from spicevmc.xml
error: invalid argument: device not present in domain configuration
# virsh destroy r7
error: Failed to destroy domain r7
error: End of file while reading data: Input/output error
error: Failed to reconnect to the hypervisor
=============================================
Verify it as follows. libvirt don't core dump.
Version:
libvirt-1.2.8-9.el7.x86_64
qemu-kvm-rhev-2.1.2-13.el7.x86_64
qemu-kvm-1.5.3-82.el7.x86_64
Steps:
# cat spicevmc.xml
<channel type='spicevmc'>
<target type='virtio' name='com.redhat.spice.0'/>
<address type='virtio-serial' controller='0' bus='0' port='1'/>
</channel>
# virsh start r7
Domain r7 started
# virsh attach-device r7 spicevmc.xml
error: Failed to attach device from spicevmc.xml
error: Requested operation is not valid: chardev already exists
# virsh destroy r7
Domain r7 destroyed
Additional info:
For NULL and VC type chardevs, test results are the same as SPICEVMC chardevs.
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://rhn.redhat.com/errata/RHSA-2015-0323.html |