Bug 1162108
| Summary: | Unable to delete 'active' namespaces via cleanup utility with "force" attribute | ||||||
|---|---|---|---|---|---|---|---|
| Product: | Red Hat OpenStack | Reporter: | Toni Freger <tfreger> | ||||
| Component: | openstack-neutron | Assignee: | Miguel Angel Ajo <mangelajo> | ||||
| Status: | CLOSED ERRATA | QA Contact: | Toni Freger <tfreger> | ||||
| Severity: | urgent | Docs Contact: | |||||
| Priority: | high | ||||||
| Version: | 5.0 (RHEL 7) | CC: | amuller, chrisw, ihrachys, lpeer, majopela, nyechiel, oblaut, yeylon | ||||
| Target Milestone: | z3 | Keywords: | ZStream | ||||
| Target Release: | 5.0 (RHEL 7) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Whiteboard: | |||||||
| Fixed In Version: | openstack-neutron-2014.1.3-11.el6ost openstack-neutron-2014.1.3-10.el7ost | Doc Type: | Bug Fix | ||||
| Doc Text: | Story Points: | --- | |||||
| Clone Of: | Environment: | ||||||
| Last Closed: | 2014-12-02 17:00:27 UTC | Type: | Bug | ||||
| Regression: | --- | Mount Type: | --- | ||||
| Documentation: | --- | CRM: | |||||
| Verified Versions: | Category: | --- | |||||
| oVirt Team: | --- | RHEL 7.3 requirements from Atomic Host: | |||||
| Cloudforms Team: | --- | Target Upstream Version: | |||||
| Embargoed: | |||||||
| Bug Depends On: | 1163470 | ||||||
| Bug Blocks: | 1161524 | ||||||
| Attachments: |
|
||||||
|
Description
Toni Freger
2014-11-10 09:53:17 UTC
Copying from email:
Miguel has backported process monitor patches to RHOSP5, and it seems
that cleanup utils were broken. The failure is as follows:
DhcpLocalProcess.active() was modified to use process monitor to track
process state. For this to work, process monitor should be passed when
the class is instantiated. The problem is that cleanup tools were not
updated to do so.
The problematic part is: neutron/agent/netns_cleanup_util.py
dhcp_driver = importutils.import_object(
conf.dhcp_driver,
conf=conf,
network=dhcp.NetModel(conf.use_namespaces, {'id': network_id}),
root_helper=root_helper,
plugin=FakeDhcpPlugin())
As you can see, there is no process monitor argument appended, hence
the failure. I think we should:
1) pass the argument in cleanup tools;
2) make it required (atm it's =None, allowing such failures to sneak).
The fix itself is easy, though we may need to make patch reshuffling
(or just band aid existing backports).
Fixing upstream kilo. Including the fix downstream as a last patch in the series. Created attachment 956753 [details]
Netns cleanup fix tracking upstream changes in a single patch for later releases.
The fix is not complete, dnsmasqs won't be deleted, I also found the backport broke something else (reload of dnsmasq config file when we restart the agent) filling a new blocker for that. Tested in Rhel7 AIO + Compute node OpenStack/5.0-RHEL-7/2014-11-14.1 openstack-neutron-2014.1.3-10.el7ost.noarch openstack-neutron-ml2-2014.1.3-10.el7ost.noarch openstack-neutron-metering-agent-2014.1.3-10.el7ost.noarch openstack-neutron-openvswitch-2014.1.3-10.el7ost.noarch These two cleanup options work as expected without errors messages: 1) neutron-netns-cleanup --config-file=/etc/neutron/neutron.conf --config-file=/etc/neutron/dhcp_agent.ini --force 2) neutron-netns-cleanup --config-file=/etc/neutron/neutron.conf --config-file=/etc/neutron/dhcp_agent.ini Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://rhn.redhat.com/errata/RHSA-2014-1942.html |