Bug 1162150

Summary:	AFR gives EROFS when fop fails on all subvolumes when client-quorum is enabled
Product:	[Community] GlusterFS	Reporter:	Pranith Kumar K <pkarampu>
Component:	replicate	Assignee:	Pranith Kumar K <pkarampu>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	urgent	Docs Contact:
Priority:	urgent
Version:	3.5.3	CC:	bugs, csuleski, cww, gluster-bugs, ndevos, storage-qa-internal, vagarwal
Target Milestone:	---
Target Release:	---
Hardware:	x86_64
OS:	Linux
Whiteboard:
Fixed In Version:	glusterfs-3.5.4	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	1162122	Environment:
Last Closed:	2015-06-03 21:08:23 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1156224, 1157976, 1162122
Bug Blocks:	1141158

Comment 1 Anand Avati 2014-11-10 11:43:52 UTC

REVIEW: http://review.gluster.org/9088 (cluster/afr: Preserve errno in case of failures on all subvols) posted (#2) for review on release-3.5 by Pranith Kumar Karampuri (pkarampu)

Comment 2 Anand Avati 2015-02-11 10:13:50 UTC

COMMIT: http://review.gluster.org/9088 committed in release-3.5 by Niels de Vos (ndevos) 
------
commit 72e84c17240bc46c1a040cb585c4a3c89c58903d
Author: Pranith Kumar K <pkarampu>
Date:   Mon Nov 10 16:19:34 2014 +0530

    cluster/afr: Preserve errno in case of failures on all subvols
    
            Partly backported from http://review.gluster.org/8984
    
    Problem:
    When quorum is enabled and the fop fails on all the subvolumes,
    op_errno is set to EROFS which overrides the actual errno returned
    from bricks.
    
    Fix:
    Don't override the errno when fop fails on all subvols.
    
    PS: Afr-v2 code differs from afr-v1 so that pre-op part of code doesn't apply
    
    Change-Id: I61e57bbf1a69407230ec172a983de18d1c624fd2
    BUG: 1162150
    Signed-off-by: Pranith Kumar K <pkarampu>
    Reviewed-on: http://review.gluster.org/9088
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Niels de Vos <ndevos>

Comment 3 Niels de Vos 2015-06-03 21:08:23 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.5.4, please reopen this bug report.

glusterfs-3.5.4 has been announced on the Gluster Packaging mailinglist [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.packaging/2
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user