Bug 1162213

Summary:	fstrim doens't understand bind mounts
Product:	[Fedora] Fedora	Reporter:	Vratislav Podzimek <vpodzime>
Component:	util-linux	Assignee:	Karel Zak <kzak>
Status:	CLOSED NEXTRELEASE	QA Contact:	Fedora Extras Quality Assurance <extras-qa>
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	22	CC:	jonathan, kzak
Target Milestone:	---	Keywords:	Reopened
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:		Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:		Environment:
Last Closed:	2015-06-10 12:39:56 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:

Description Vratislav Podzimek 2014-11-10 14:28:38 UTC

Description of problem:
When running 'fstrim -av' on a machine that has some bind mounts, the TRIM operation is run multiple times on those filesystems that are bind-mounted in multiple places.

Version-Release number of selected component (if applicable):
util-linux-2.24.2-1.fc20.x86_64

How reproducible:
100 %

Steps to Reproduce:
1. setup a machine with bind mounts
2. run fstrim -av

Actual results:
the bind-mounted filesystem(s) TRIMed multiple times

Expected results:
each filesystem TRIMed only once

Comment 1 Karel Zak 2014-11-11 12:01:24 UTC

Already improved in v 2.25 (f21).

Comment 2 Vratislav Podzimek 2014-11-11 14:59:48 UTC

(In reply to Karel Zak from comment #1)
> Already improved in v 2.25 (f21).
No, it's not. I can reproduce the issue with fstrim from util-linux-2.25.2-1.fc21 too.

Comment 3 Fedora End Of Life 2015-05-29 13:15:55 UTC

This message is a reminder that Fedora 20 is nearing its end of life.
Approximately 4 (four) weeks from now Fedora will stop maintaining
and issuing updates for Fedora 20. It is Fedora's policy to close all
bug reports from releases that are no longer maintained. At that time
this bug will be closed as EOL if it remains open with a Fedora  'version'
of '20'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 20 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 4 Vratislav Podzimek 2015-06-10 07:24:07 UTC

Still the same, even on F22 (util-linux-2.26.2)

Comment 5 Karel Zak 2015-06-10 12:39:56 UTC

The de-duplication by mount source (relevant for bind mounts) is implemented by upstream commit 8dd51c183396c4bf6344d08b01fb84658e0a8eb4.

The change will be available in f23 (util-linux-2.27).