Bug 1163108

Summary:	gluster accepts invalid values when changing cluster.min-free-disk option
Product:	[Community] GlusterFS	Reporter:	Gaurav Kumar Garg <ggarg>
Component:	distribute	Assignee:	Gaurav Kumar Garg <ggarg>
Status:	CLOSED CURRENTRELEASE	QA Contact:
Severity:	unspecified	Docs Contact:
Priority:	unspecified
Version:	pre-release	CC:	amukherj, bugs, gluster-bugs, nlevinki, okomarek, rhs-bugs, smohan, storage-qa-internal, vbellur
Target Milestone:	---	Keywords:	Triaged
Target Release:	---
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	glusterfs-3.7.0	Doc Type:	Bug Fix
Doc Text:		Story Points:	---
Clone Of:	1144015	Environment:
Last Closed:	2015-05-14 17:28:26 UTC	Type:	Bug
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:	1144015
Bug Blocks:

Comment 1 Anand Avati 2014-11-12 12:28:50 UTC

REVIEW: http://review.gluster.org/9104 (DHT: cluster.min-free-disk option should validate correctly) posted (#1) for review on master by Gaurav Kumar Garg (ggarg)

Comment 2 Anand Avati 2014-11-13 07:36:20 UTC

REVIEW: http://review.gluster.org/9104 (DHT: cluster.min-free-disk option should validate correctly) posted (#2) for review on master by Gaurav Kumar Garg (ggarg)

Comment 3 Anand Avati 2014-11-13 14:00:50 UTC

REVIEW: http://review.gluster.org/9104 (DHT: cluster.min-free-disk option should validate correctly) posted (#3) for review on master by Gaurav Kumar Garg (ggarg)

Comment 4 Anand Avati 2014-12-29 10:23:13 UTC

REVIEW: http://review.gluster.org/9104 (DHT: cluster.min-free-disk option should validate correctly) posted (#4) for review on master by Gaurav Kumar Garg (ggarg)

Comment 5 Anand Avati 2014-12-29 13:27:33 UTC

REVIEW: http://review.gluster.org/9104 (DHT: cluster.min-free-disk option should validate correctly) posted (#5) for review on master by Gaurav Kumar Garg (ggarg)

Comment 6 Anand Avati 2015-01-04 09:48:46 UTC

REVIEW: http://review.gluster.org/9104 (DHT: cluster.min-free-disk option should validate correctly) posted (#6) for review on master by Gaurav Kumar Garg (ggarg)

Comment 7 Anand Avati 2015-01-05 13:43:40 UTC

REVIEW: http://review.gluster.org/9104 (DHT: cluster.min-free-disk option should validate correctly) posted (#7) for review on master by Gaurav Kumar Garg (ggarg)

Comment 8 Anand Avati 2015-01-06 08:45:15 UTC

REVIEW: http://review.gluster.org/9104 (DHT: cluster.min-free-disk option should validate correctly) posted (#8) for review on master by Gaurav Kumar Garg (ggarg)

Comment 9 Anand Avati 2015-01-08 13:38:23 UTC

REVIEW: http://review.gluster.org/9104 (DHT: cluster.min-free-disk option should validate correctly) posted (#9) for review on master by Gaurav Kumar Garg (ggarg)

Comment 10 Anand Avati 2015-01-19 06:33:00 UTC

REVIEW: http://review.gluster.org/9104 (DHT: cluster.min-free-disk option should validate correctly) posted (#10) for review on master by Gaurav Kumar Garg (ggarg)

Comment 11 Anand Avati 2015-01-21 05:28:54 UTC

REVIEW: http://review.gluster.org/9104 (DHT: cluster.min-free-disk option should validate correctly) posted (#11) for review on master by Gaurav Kumar Garg (ggarg)

Comment 12 Anand Avati 2015-01-21 08:58:53 UTC

REVIEW: http://review.gluster.org/9104 (DHT: cluster.min-free-disk option should validate correctly) posted (#12) for review on master by Gaurav Kumar Garg (ggarg)

Comment 13 Anand Avati 2015-02-05 06:02:46 UTC

COMMIT: http://review.gluster.org/9104 committed in master by Vijay Bellur (vbellur) 
------
commit e44d4e135747b04a5e2b7cfac21f9a3343e071db
Author: GauravKumarGarg <ggarg>
Date:   Wed Nov 12 17:41:33 2014 +0530

    DHT: cluster.min-free-disk option should validate correctly
    
    PROBLEM:
    Previously gluster accepting input value as a percentage which is out of range
    [0-100] and accepting input value as a size (unit is byte) which is fractional
    for option cluster.min-free-disk.
    
    FIX:
    Now with this change it will refer to correct validation function
    and it will accept value that is in range [0-100] for input value as a
    percentage and unsigned integer value for input as a size (unit in byte)
    for option cluster.min-free-disk.
    
    Change-Id: Iee1962a100542e146276cfc8a4068abddee2bf2d
    BUG: 1163108
    Signed-off-by: Gaurav Kumar Garg <ggarg>
    Reviewed-on: http://review.gluster.org/9104
    Tested-by: Gluster Build System <jenkins.com>
    Reviewed-by: Krishnan Parthasarathi <kparthas>
    Reviewed-by: Raghavendra G <rgowdapp>
    Reviewed-by: Vijay Bellur <vbellur>

Comment 14 Niels de Vos 2015-05-14 17:28:26 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 15 Niels de Vos 2015-05-14 17:35:42 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 16 Niels de Vos 2015-05-14 17:38:04 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user

Comment 17 Niels de Vos 2015-05-14 17:44:50 UTC

This bug is getting closed because a release has been made available that should address the reported issue. In case the problem is still not fixed with glusterfs-3.7.0, please open a new bug report.

glusterfs-3.7.0 has been announced on the Gluster mailinglists [1], packages for several distributions should become available in the near future. Keep an eye on the Gluster Users mailinglist [2] and the update infrastructure for your distribution.

[1] http://thread.gmane.org/gmane.comp.file-systems.gluster.devel/10939
[2] http://thread.gmane.org/gmane.comp.file-systems.gluster.user